From 2be76fca4bf7496e8c03bbf2b1aaf8341f937e8a Mon Sep 17 00:00:00 2001 From: Victor Gomes Date: Mon, 6 Feb 2023 13:21:06 +0100 Subject: [PATCH] [maglev] Set --maglev-inlining as experimental Bug: v8:7700 Change-Id: Ida08a24e91149cbc895eb7328774a1154a2e15db Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4218741 Reviewed-by: Leszek Swirski Auto-Submit: Victor Gomes Commit-Queue: Victor Gomes Cr-Commit-Position: refs/heads/main@{#85678} --- src/flags/flag-definitions.h | 4 ++-- tools/testrunner/local/variants.py | 1 + 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/src/flags/flag-definitions.h b/src/flags/flag-definitions.h index 14a4a272a9..0c1d2dc34a 100644 --- a/src/flags/flag-definitions.h +++ b/src/flags/flag-definitions.h @@ -482,8 +482,8 @@ DEFINE_BOOL(lower_tier_as_toptier, false, #define V8_ENABLE_MAGLEV_BOOL true DEFINE_BOOL(maglev, false, "enable the maglev optimizing compiler") DEFINE_WEAK_IMPLICATION(future, maglev) -DEFINE_BOOL(maglev_inlining, false, - "enable inlining in the maglev optimizing compiler") +DEFINE_EXPERIMENTAL_FEATURE(maglev_inlining, + "enable inlining in the maglev optimizing compiler") DEFINE_BOOL(maglev_reuse_stack_slots, true, "reuse stack slots in the maglev optimizing compiler") diff --git a/tools/testrunner/local/variants.py b/tools/testrunner/local/variants.py index 876dcd6efc..32afc73f40 100644 --- a/tools/testrunner/local/variants.py +++ b/tools/testrunner/local/variants.py @@ -70,6 +70,7 @@ kIncompatibleFlagsForNoTurbofan = [ # variant. This depends on the flags specified in ALL_VARIANT_FLAGS and on the # implications defined in flag-definitions.h. INCOMPATIBLE_FLAGS_PER_VARIANT = { + "future": ["--experimental", "--maglev-inlining"], "jitless": kIncompatibleFlagsForNoTurbofan + [ "--track-field-types", "--sparkplug", "--concurrent-sparkplug",