From 2be8412069645a3c0020432853fd16639d3d5d49 Mon Sep 17 00:00:00 2001 From: Wenyu Zhao Date: Mon, 26 Apr 2021 12:31:14 +1000 Subject: [PATCH] [heap] Several implication rules for third party heap MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Bug: v8:11641 Change-Id: I2b7fb85fa4e2890787981af1559f535b76ec8b05 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2849815 Reviewed-by: Ulan Degenbaev Reviewed-by: Dominik Inführ Commit-Queue: Wenyu Zhao Cr-Commit-Position: refs/heads/master@{#74216} --- BUILD.gn | 6 ++++++ src/flags/flag-definitions.h | 5 +++++ 2 files changed, 11 insertions(+) diff --git a/BUILD.gn b/BUILD.gn index cd7117d65c..6cdd3f94d3 100644 --- a/BUILD.gn +++ b/BUILD.gn @@ -384,6 +384,12 @@ if (v8_enable_atomic_object_field_writes == "") { if (v8_enable_atomic_marking_state == "") { v8_enable_atomic_marking_state = v8_enable_concurrent_marking } +if (v8_enable_third_party_heap) { + v8_disable_write_barriers = true + v8_enable_single_generation = true + v8_enable_shared_ro_heap = false + v8_enable_pointer_compression = false +} assert(!v8_enable_concurrent_marking || v8_enable_atomic_object_field_writes, "Concurrent marking requires atomic object field writes.") assert(!v8_enable_concurrent_marking || v8_enable_atomic_marking_state, diff --git a/src/flags/flag-definitions.h b/src/flags/flag-definitions.h index 7f980f9f82..0dd4f2252d 100644 --- a/src/flags/flag-definitions.h +++ b/src/flags/flag-definitions.h @@ -383,6 +383,11 @@ DEFINE_IMPLICATION(lite_mode, optimize_for_size) DEFINE_NEG_IMPLICATION(enable_third_party_heap, inline_new) DEFINE_NEG_IMPLICATION(enable_third_party_heap, allocation_site_pretenuring) DEFINE_NEG_IMPLICATION(enable_third_party_heap, turbo_allocation_folding) +DEFINE_NEG_IMPLICATION(enable_third_party_heap, concurrent_recompilation) +DEFINE_NEG_IMPLICATION(enable_third_party_heap, concurrent_inlining) +DEFINE_NEG_IMPLICATION(enable_third_party_heap, + finalize_streaming_on_background) +DEFINE_NEG_IMPLICATION(enable_third_party_heap, use_marking_progress_bar) DEFINE_BOOL_READONLY(enable_third_party_heap, V8_ENABLE_THIRD_PARTY_HEAP_BOOL, "Use third-party heap")