AuroraMiddleware/v8
1
0
Fork 0
Code Issues 2 Pull Requests Releases Wiki Activity

Move some more ENTER_V8 invocations. The biggest one is to move the

Browse Source 
one in v8::V8::Initialize to after the early bailout.
Review URL: http://codereview.chromium.org/60083

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@1673 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
This commit is contained in:
kmillikin@chromium.org 2009-04-03 08:18:24 +00:00
parent 35d6c8fb03
commit 2c5ce41876
1 changed files with 15 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

24
src/api.cc
View File

@ -1455,11 +1455,14 @@ Local<v8::Object> Value::ToObject() const {
Local<Boolean> Value::ToBoolean() const {
if (IsDeadCheck("v8::Value::ToBoolean()")) return Local<Boolean>();
LOG_API("ToBoolean");
ENTER_V8;
i::Handle<i::Object> obj = Utils::OpenHandle(this);
i::Handle<i::Object> val =
obj->IsBoolean() ? obj : i::Execution::ToBoolean(obj);
return Local<Boolean>(ToApi<Boolean>(val));
if (obj->IsBoolean()) {
return Local<Boolean>(ToApi<Boolean>(obj));
} else {
ENTER_V8;
i::Handle<i::Object> val = i::Execution::ToBoolean(obj);
return Local<Boolean>(ToApi<Boolean>(val));
}
}
@ -1580,11 +1583,14 @@ v8::Date* v8::Date::Cast(v8::Value* that) {
bool Value::BooleanValue() const {
if (IsDeadCheck("v8::Value::BooleanValue()")) return false;
LOG_API("BooleanValue");
ENTER_V8;
i::Handle<i::Object> obj = Utils::OpenHandle(this);
i::Handle<i::Object> value =
obj->IsBoolean() ? obj : i::Execution::ToBoolean(obj);
return value->IsTrue();
if (obj->IsBoolean()) {
return obj->IsTrue();
} else {
ENTER_V8;
i::Handle<i::Object> value = i::Execution::ToBoolean(obj);
return value->IsTrue();
}
}
@ -2347,8 +2353,8 @@ void v8::Object::SetInternalField(int index, v8::Handle<Value> value) {
// --- E n v i r o n m e n t ---
bool v8::V8::Initialize() {
ENTER_V8;
if (i::V8::HasBeenSetup()) return true;
ENTER_V8;
HandleScope scope;
if (i::Snapshot::Initialize()) {
return true;