AuroraMiddleware/v8
1
0
Fork 0
Code Issues 2 Pull Requests Releases Wiki Activity

Revert "[nci] Enable --turbo-nci behind --future to gather perf data"

Browse Source 
This reverts commit c3b2b64be4.

Reason for revert: Scheduled revert.

The flag flip is in 88.0.4315.0. Group report links:

https://chromeperf.appspot.com/group_report?rev=70949
https://chromeperf.appspot.com/group_report?rev=823663

Original change's description:
> [nci] Enable --turbo-nci behind --future to gather perf data
>
> .. to be reverted in a day or two.
>
> Bug: v8:8888
> Change-Id: Iee156da614b50c351ca9a07cc497177c92de865d
> Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2512907
> Commit-Queue: Jakob Gruber <jgruber@chromium.org>
> Reviewed-by: Lutz Vahl <vahl@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#70949}

TBR=machenbach@chromium.org,jgruber@chromium.org,vahl@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: v8:8888,v8:11087
Change-Id: I57411474d885dd69613a85f5fa3a801a573fcd08
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2517690
Reviewed-by: Jakob Gruber <jgruber@chromium.org>
Reviewed-by: Michael Achenbach <machenbach@chromium.org>
Commit-Queue: Jakob Gruber <jgruber@chromium.org>
Cr-Commit-Position: refs/heads/master@{#70982}
This commit is contained in:
Jakob Gruber 2020-11-05 05:57:17 +00:00 committed by Commit Bot
parent 5f1a742ebe
commit 2dc1799585
3 changed files with 4 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
src/flags/flag-definitions.h
View File

@ -424,11 +424,6 @@ DEFINE_BOOL(future, FUTURE_BOOL,
DEFINE_WEAK_IMPLICATION(future, write_protect_code_memory)
DEFINE_WEAK_IMPLICATION(future, finalize_streaming_on_background)
DEFINE_WEAK_IMPLICATION(future, super_ic)
#ifdef V8_TARGET_ARCH_X64
// Enabled for a few rolls to gather perf data. See also:
// https://bugs.chromium.org/p/v8/issues/detail?id=11087
DEFINE_WEAK_IMPLICATION(future, turbo_nci)
#endif
// Flags for jitless
DEFINE_BOOL(jitless, V8_LITE_BOOL,

5
test/cctest/cctest.status
View File

@ -657,8 +657,7 @@
}],
################################################################################
['variant == nci or variant == nci_as_midtier or variant == future', {
# TODO(jgruber): Exclude the future variant again.
['variant == nci or variant == nci_as_midtier', {
# Optimizes and deopts differently than TurboFan.
'test-api/FastApiCalls': [SKIP],
'test-cpu-profiler/Deopt*': [SKIP],
@ -675,6 +674,6 @@
# NCI code currently does not use the feedback vector's optimized code cache.
'test-compiler/OptimizedCodeSharing1': [SKIP],
}], # variant == nci or variant == nci_as_midtier or variant == future
}], # variant == nci or variant == nci_as_midtier
]

5
test/mjsunit/mjsunit.status
View File

@ -1303,8 +1303,7 @@
}], # variant == slow_path
################################################################################
['variant == nci or variant == nci_as_midtier or variant == future', {
# TODO(jgruber): Exclude the future variant again.
['variant == nci or variant == nci_as_midtier', {
# Deopts differently than TurboFan.
# Deoptimization support is still incomplete in general, since deopts can
# only happen when explicitly requested by tests. NCI code objects are then
@ -1433,7 +1432,7 @@
'compiler/serializer-feedback-propagation-1': [SKIP],
'compiler/serializer-feedback-propagation-2': [SKIP],
'compiler/serializer-transition-propagation': [SKIP],
}], # variant == nci or variant == nci_as_midtier or variant == future
}], # variant == nci or variant == nci_as_midtier
['((arch == mipsel or arch == mips64el or arch == mips or arch == mips64) and not simd_mips) or (arch in [ppc64, s390x])', {
# Requires scalar lowering for 64x2 SIMD instructions, which are not