[regexp] Standardize handling of stack overflow crash in ToNode
Use the FatalProcessOutOfMemory function such that tooling recognizes these crashes as OOM's. Drive-by: Skip one more test that leads to such stack overflows. Fixed: v8:12555, chromium:1288456 Bug: v8:12472 Change-Id: Ib9203a4aa0487744f7cea9a212aeeffda579ae23 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3401861 Auto-Submit: Jakob Gruber <jgruber@chromium.org> Reviewed-by: Clemens Backes <clemensb@chromium.org> Commit-Queue: Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/heads/main@{#78692}
This commit is contained in:
parent
5218f60962
commit
2edff88402
@ -3951,7 +3951,9 @@ RegExpNode* RegExpCompiler::PreprocessRegExp(RegExpCompileData* data,
|
||||
}
|
||||
|
||||
void RegExpCompiler::ToNodeCheckForStackOverflow() {
|
||||
CHECK(!StackLimitCheck{isolate()}.HasOverflowed());
|
||||
if (StackLimitCheck{isolate()}.HasOverflowed()) {
|
||||
FatalProcessOutOfMemory(isolate(), "RegExpCompiler");
|
||||
}
|
||||
}
|
||||
|
||||
} // namespace internal
|
||||
|
@ -182,6 +182,7 @@
|
||||
|
||||
# crbug.com/v8/12472 Stack overflow during regexp node generation.
|
||||
'regress/regress-crbug-595657': [SKIP],
|
||||
'regress/regress-475705': [SKIP],
|
||||
|
||||
##############################################################################
|
||||
# Tests where variants make no sense.
|
||||
|
Loading…
Reference in New Issue
Block a user