AuroraMiddleware/v8
1
0
Fork 0
Code Issues 2 Pull Requests Releases Wiki Activity

Revert "heap: Fix compaction aborting all pages"

Browse Source 
This reverts commit 18236dcbea.

Reason for revert: https://ci.chromium.org/ui/p/v8/builders/ci/V8%20Linux64%20TSAN%20-%20no-concurrent-marking/6576/overview

Original change's description:
> heap: Fix compaction aborting all pages
>
> In such a case, we must post-process all aborted pages. The early
> bailout assumed that not pages are aborted before trying compaction.
>
> Bug: chromium:1271229
> Change-Id: I4c5998b9d1c7974f7d1d25a6729f42d5690a5759
> Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3289171
> Reviewed-by: Hannes Payer <hpayer@chromium.org>
> Reviewed-by: Dominik Inführ <dinfuehr@chromium.org>
> Commit-Queue: Michael Lippautz <mlippautz@chromium.org>
> Cr-Commit-Position: refs/heads/main@{#77987}

Bug: chromium:1271229
Change-Id: Ia4b8687a0f3742bf0c894989f68c249b6c87c446
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3291900
Auto-Submit: Zhi An Ng <zhin@chromium.org>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Commit-Queue: Deepti Gandluri <gdeepti@chromium.org>
Owners-Override: Deepti Gandluri <gdeepti@chromium.org>
Cr-Commit-Position: refs/heads/main@{#77988}
This commit is contained in:
Zhi An Ng 2021-11-18 21:15:46 +00:00 committed by V8 LUCI CQ
parent 18236dcbea
commit 2f17c06963
1 changed files with 9 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
src/heap/mark-compact.cc
View File

@ -3606,16 +3606,16 @@ void MarkCompactCollector::EvacuatePagesInParallel() {
}
}
const size_t pages_count = evacuation_items.size();
size_t wanted_num_tasks = 0;
if (!evacuation_items.empty()) {
TRACE_EVENT1(TRACE_DISABLED_BY_DEFAULT("v8.gc"),
"MarkCompactCollector::EvacuatePagesInParallel", "pages",
evacuation_items.size());
if (evacuation_items.empty()) return;
wanted_num_tasks = CreateAndExecuteEvacuationTasks<FullEvacuator>(
this, std::move(evacuation_items), nullptr);
}
TRACE_EVENT1(TRACE_DISABLED_BY_DEFAULT("v8.gc"),
"MarkCompactCollector::EvacuatePagesInParallel", "pages",
evacuation_items.size());
const size_t pages_count = evacuation_items.size();
const size_t wanted_num_tasks =
CreateAndExecuteEvacuationTasks<FullEvacuator>(
this, std::move(evacuation_items), nullptr);
// After evacuation there might still be swept pages that weren't
// added to one of the compaction space but still reside in the