AuroraMiddleware/v8
1
0
Fork 0
Code Issues 2 Pull Requests Releases Wiki Activity

[wasm][debug] Move debug-evaluate cctest to Liftoff

Browse Source 
This is the last cctest that uses the interpreter for debugging.
This CL moves it over to Liftoff.

R=jkummerow@chromium.org

Bug: v8:10389
Change-Id: I1791f0c762c9aab38eee5f5fb96772f4d01c212f
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2164790
Reviewed-by: Jakob Kummerow <jkummerow@chromium.org>
Commit-Queue: Clemens Backes <clemensb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#67367}
This commit is contained in:
Clemens Backes 2020-04-24 16:17:08 +02:00 committed by Commit Bot
parent 886d676de3
commit 30350b6575
2 changed files with 3 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/execution/frames.h
View File

@ -955,7 +955,7 @@ class WasmCompiledFrame : public StandardFrame {
Code unchecked_code() const override;
// Accessors.
WasmInstanceObject wasm_instance() const;
V8_EXPORT_PRIVATE WasmInstanceObject wasm_instance() const;
V8_EXPORT_PRIVATE wasm::NativeModule* native_module() const;
wasm::WasmCode* wasm_code() const;
uint32_t function_index() const;

13
test/cctest/wasm/test-wasm-debug-evaluate.cc
View File

@ -72,14 +72,6 @@ class TestCode {
break_index++, runner->main_isolate()->factory()->empty_string());
CHECK(WasmScript::SetBreakPoint(script, &return_offset_in_module,
break_point));
int set_breakpoint_offset = return_offset_in_module - function_offset;
// Also set breakpoint on the debug info of the instance directly, since
// the instance chain is not set up properly in tests.
Handle<WasmDebugInfo> debug_info =
WasmInstanceObject::GetOrCreateDebugInfo(instance);
WasmDebugInfo::SetBreakpoint(debug_info, function_index,
set_breakpoint_offset);
return break_point;
}
@ -212,9 +204,8 @@ class WasmBreakHandler : public debug::DebugDelegate {
// Check the current position.
StackTraceFrameIterator frame_it(isolate_);
FrameSummary::WasmInterpretedFrameSummary summary =
FrameSummary::GetTop(frame_it.frame()).AsWasmInterpreted();
Handle<WasmInstanceObject> instance = summary.wasm_instance();
WasmCompiledFrame* frame = WasmCompiledFrame::cast(frame_it.frame());
Handle<WasmInstanceObject> instance{frame->wasm_instance(), isolate_};
MaybeHandle<String> result_handle = v8::internal::wasm::DebugEvaluate(
{evaluator_bytes_.begin(), evaluator_bytes_.size()}, instance,