From 3053b3b71f69ee46e140d6a022bd854f4398b673 Mon Sep 17 00:00:00 2001 From: Lu Yahan Date: Tue, 15 Feb 2022 09:54:15 +0800 Subject: [PATCH] [riscv64] Delete a confirmed fix me comment Change-Id: I5b17019a991f1540c0ecc1db0a94097334e5e335 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3463060 Reviewed-by: ji qiu Commit-Queue: ji qiu Cr-Commit-Position: refs/heads/main@{#79112} --- src/codegen/riscv64/macro-assembler-riscv64.cc | 4 ---- 1 file changed, 4 deletions(-) diff --git a/src/codegen/riscv64/macro-assembler-riscv64.cc b/src/codegen/riscv64/macro-assembler-riscv64.cc index d6bff17569..e3af38964c 100644 --- a/src/codegen/riscv64/macro-assembler-riscv64.cc +++ b/src/codegen/riscv64/macro-assembler-riscv64.cc @@ -4940,10 +4940,6 @@ void TurboAssembler::CallCFunctionHelper(Register function, Register scratch = t2; auipc(pc_scratch, 0); - // TODO(RISCV): Does this need an offset? It seems like this should be the - // PC of the call, but MIPS does not seem to do that. - // https://github.com/v8-riscv/v8/issues/378 - // See x64 code for reasoning about how to address the isolate data fields. if (root_array_available()) { Sd(pc_scratch, MemOperand(kRootRegister,