AuroraMiddleware/v8
1
0
Fork 0
Code Issues 2 Pull Requests Releases Wiki Activity

Const-corrected some MachineSignature* parameters.

Browse Source 
Recipe: Add "const" to RawMachineAssembler constructor, fix breakage.

Review URL: https://codereview.chromium.org/874693006

Cr-Commit-Position: refs/heads/master@{#26485}
This commit is contained in:
svenpanne 2015-02-06 04:18:44 -08:00 committed by Commit bot
parent 878963a8a5
commit 30787d4e56
11 changed files with 17 additions and 16 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/compiler/arm/linkage-arm.cc
View File

@ -60,7 +60,7 @@ CallDescriptor* Linkage::GetStubCallDescriptor(
CallDescriptor* Linkage::GetSimplifiedCDescriptor(Zone* zone, CallDescriptor* Linkage::GetSimplifiedCDescriptor(Zone* zone,
MachineSignature* sig) { const MachineSignature* sig) {
return LH::GetSimplifiedCDescriptor(zone, sig); return LH::GetSimplifiedCDescriptor(zone, sig);
} }

2
src/compiler/arm64/linkage-arm64.cc
View File

@ -60,7 +60,7 @@ CallDescriptor* Linkage::GetStubCallDescriptor(
CallDescriptor* Linkage::GetSimplifiedCDescriptor(Zone* zone, CallDescriptor* Linkage::GetSimplifiedCDescriptor(Zone* zone,
MachineSignature* sig) { const MachineSignature* sig) {
return LH::GetSimplifiedCDescriptor(zone, sig); return LH::GetSimplifiedCDescriptor(zone, sig);
} }

2
src/compiler/ia32/linkage-ia32.cc
View File

@ -55,7 +55,7 @@ CallDescriptor* Linkage::GetStubCallDescriptor(
CallDescriptor* Linkage::GetSimplifiedCDescriptor(Zone* zone, CallDescriptor* Linkage::GetSimplifiedCDescriptor(Zone* zone,
MachineSignature* sig) { const MachineSignature* sig) {
return LH::GetSimplifiedCDescriptor(zone, sig); return LH::GetSimplifiedCDescriptor(zone, sig);
} }

4
src/compiler/linkage-impl.h
View File

@ -192,8 +192,8 @@ class LinkageHelper {
descriptor.DebugName(isolate)); descriptor.DebugName(isolate));
} }
static CallDescriptor* GetSimplifiedCDescriptor(Zone* zone, static CallDescriptor* GetSimplifiedCDescriptor(
MachineSignature* msig) { Zone* zone, const MachineSignature* msig) {
LocationSignature::Builder locations(zone, msig->return_count(), LocationSignature::Builder locations(zone, msig->return_count(),
msig->parameter_count()); msig->parameter_count());
// Add return location(s). // Add return location(s).

7
src/compiler/linkage.h
View File

@ -64,8 +64,9 @@ class CallDescriptor FINAL : public ZoneObject {
typedef base::Flags<Flag> Flags; typedef base::Flags<Flag> Flags;
CallDescriptor(Kind kind, MachineType target_type, LinkageLocation target_loc, CallDescriptor(Kind kind, MachineType target_type, LinkageLocation target_loc,
MachineSignature* machine_sig, LocationSignature* location_sig, const MachineSignature* machine_sig,
size_t js_param_count, Operator::Properties properties, LocationSignature* location_sig, size_t js_param_count,
Operator::Properties properties,
RegList callee_saved_registers, Flags flags, RegList callee_saved_registers, Flags flags,
const char* debug_name = "") const char* debug_name = "")
: kind_(kind), : kind_(kind),
@ -209,7 +210,7 @@ class Linkage : public ZoneObject {
// integers and pointers of one word size each, i.e. no floating point, // integers and pointers of one word size each, i.e. no floating point,
// structs, pointers to members, etc. // structs, pointers to members, etc.
static CallDescriptor* GetSimplifiedCDescriptor(Zone* zone, static CallDescriptor* GetSimplifiedCDescriptor(Zone* zone,
MachineSignature* sig); const MachineSignature* sig);
// Get the location of an (incoming) parameter to this function. // Get the location of an (incoming) parameter to this function.
LinkageLocation GetParameterLocation(int index) const { LinkageLocation GetParameterLocation(int index) const {

2
src/compiler/mips/linkage-mips.cc
View File

@ -60,7 +60,7 @@ CallDescriptor* Linkage::GetStubCallDescriptor(
CallDescriptor* Linkage::GetSimplifiedCDescriptor(Zone* zone, CallDescriptor* Linkage::GetSimplifiedCDescriptor(Zone* zone,
MachineSignature* sig) { const MachineSignature* sig) {
return LH::GetSimplifiedCDescriptor(zone, sig); return LH::GetSimplifiedCDescriptor(zone, sig);
} }

2
src/compiler/mips64/linkage-mips64.cc
View File

@ -60,7 +60,7 @@ CallDescriptor* Linkage::GetStubCallDescriptor(
CallDescriptor* Linkage::GetSimplifiedCDescriptor(Zone* zone, CallDescriptor* Linkage::GetSimplifiedCDescriptor(Zone* zone,
MachineSignature* sig) { const MachineSignature* sig) {
return LH::GetSimplifiedCDescriptor(zone, sig); return LH::GetSimplifiedCDescriptor(zone, sig);
} }

2
src/compiler/ppc/linkage-ppc.cc
View File

@ -62,7 +62,7 @@ CallDescriptor* Linkage::GetStubCallDescriptor(
CallDescriptor* Linkage::GetSimplifiedCDescriptor(Zone* zone, CallDescriptor* Linkage::GetSimplifiedCDescriptor(Zone* zone,
MachineSignature* sig) { const MachineSignature* sig) {
return LH::GetSimplifiedCDescriptor(zone, sig); return LH::GetSimplifiedCDescriptor(zone, sig);
} }

2
src/compiler/raw-machine-assembler.cc
View File

@ -12,7 +12,7 @@ namespace internal {
namespace compiler { namespace compiler {
RawMachineAssembler::RawMachineAssembler(Isolate* isolate, Graph* graph, RawMachineAssembler::RawMachineAssembler(Isolate* isolate, Graph* graph,
MachineSignature* machine_sig, const MachineSignature* machine_sig,
MachineType word, MachineType word,
MachineOperatorBuilder::Flags flags) MachineOperatorBuilder::Flags flags)
: GraphBuilder(isolate, graph), : GraphBuilder(isolate, graph),

6
src/compiler/raw-machine-assembler.h
View File

@ -45,7 +45,7 @@ class RawMachineAssembler : public GraphBuilder {
}; };
RawMachineAssembler(Isolate* isolate, Graph* graph, RawMachineAssembler(Isolate* isolate, Graph* graph,
MachineSignature* machine_sig, const MachineSignature* machine_sig,
MachineType word = kMachPtr, MachineType word = kMachPtr,
MachineOperatorBuilder::Flags flags = MachineOperatorBuilder::Flags flags =
MachineOperatorBuilder::Flag::kNoFlags); MachineOperatorBuilder::Flag::kNoFlags);
@ -56,7 +56,7 @@ class RawMachineAssembler : public GraphBuilder {
CommonOperatorBuilder* common() { return &common_; } CommonOperatorBuilder* common() { return &common_; }
CallDescriptor* call_descriptor() const { return call_descriptor_; } CallDescriptor* call_descriptor() const { return call_descriptor_; }
size_t parameter_count() const { return machine_sig_->parameter_count(); } size_t parameter_count() const { return machine_sig_->parameter_count(); }
MachineSignature* machine_sig() const { return machine_sig_; } const MachineSignature* machine_sig() const { return machine_sig_; }
Node* UndefinedConstant() { Node* UndefinedConstant() {
Unique<HeapObject> unique = Unique<HeapObject>::CreateImmovable( Unique<HeapObject> unique = Unique<HeapObject>::CreateImmovable(
@ -448,7 +448,7 @@ class RawMachineAssembler : public GraphBuilder {
Schedule* schedule_; Schedule* schedule_;
MachineOperatorBuilder machine_; MachineOperatorBuilder machine_;
CommonOperatorBuilder common_; CommonOperatorBuilder common_;
MachineSignature* machine_sig_; const MachineSignature* machine_sig_;
CallDescriptor* call_descriptor_; CallDescriptor* call_descriptor_;
Node** parameters_; Node** parameters_;
Label exit_label_; Label exit_label_;

2
src/compiler/x64/linkage-x64.cc
View File

@ -74,7 +74,7 @@ CallDescriptor* Linkage::GetStubCallDescriptor(
CallDescriptor* Linkage::GetSimplifiedCDescriptor(Zone* zone, CallDescriptor* Linkage::GetSimplifiedCDescriptor(Zone* zone,
MachineSignature* sig) { const MachineSignature* sig) {
return LH::GetSimplifiedCDescriptor(zone, sig); return LH::GetSimplifiedCDescriptor(zone, sig);
} }