AuroraMiddleware/v8
1
0
Fork 0
Code Issues 2 Pull Requests Releases Wiki Activity

Revert "[torque] Temporarily remove torque format check to pass presubmit"

Browse Source 
This reverts commit 91213b5c0b.

Reason for revert: Fix available

Original change's description:
> [torque] Temporarily remove torque format check to pass presubmit
> 
> Revert this once the bug is fixed.
> 
> TBR=machenbach@chromium.org
> 
> Change-Id: I32c9ef41b968e37b6de9eddb7e4e27c1d60c87c8
> Bug: v8:8873
> Notry: true
> Notreechecks: true
> Reviewed-on: https://chromium-review.googlesource.com/c/1477749
> Reviewed-by: Sigurd Schneider <sigurds@chromium.org>
> Commit-Queue: Sigurd Schneider <sigurds@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#59721}

TBR=sigurds@chromium.org

Change-Id: Icf4454ca9ed1d276fe0a0a3fa0bba3553a6b8a87
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: v8:8873
Reviewed-on: https://chromium-review.googlesource.com/c/1478197
Reviewed-by: Sigurd Schneider <sigurds@chromium.org>
Commit-Queue: Sigurd Schneider <sigurds@chromium.org>
Cr-Commit-Position: refs/heads/master@{#59734}
This commit is contained in:
Sigurd Schneider 2019-02-20 14:06:04 +00:00 committed by Commit Bot
parent 838a4ca54a
commit 3119feabfc
1 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
PRESUBMIT.py
View File

@ -96,10 +96,10 @@ def _V8PresubmitChecks(input_api, output_api):
if not CppLintProcessor().RunOnFiles(
input_api.AffectedFiles(file_filter=FilterFile, include_deletes=False)):
results.append(output_api.PresubmitError("C++ lint check failed"))
# if not TorqueLintProcessor().RunOnFiles(
# input_api.AffectedFiles(file_filter=FilterTorqueFile,
# include_deletes=False)):
# results.append(output_api.PresubmitPromptOrNotify("Torque format check failed"))
if not TorqueLintProcessor().RunOnFiles(
input_api.AffectedFiles(file_filter=FilterTorqueFile,
include_deletes=False)):
results.append(output_api.PresubmitPromptOrNotify("Torque format check failed"))
if not SourceProcessor().RunOnFiles(
input_api.AffectedFiles(include_deletes=False)):
results.append(output_api.PresubmitError(