AuroraMiddleware/v8
1
0
Fork 0
Code Issues 2 Pull Requests Releases Wiki Activity

[test] Test more wasm variants

Browse Source 
Since wasm optimizations are independent of JS optimizations, we can
just combine the "no_liftoff" variant with the existing "stress"
variant (which has the similar "--always-opt" option for JS), and add
a "Liftoff only" variant as part of "nooptimization".

This gives more coverage to find bugs like https://crrev.com/c/1543354
more easy.

R=mstarzinger@chromium.org, machenbach@chromium.org

Change-Id: I81bb22074c59dcb650a05252da43a4170cd467ac
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1559740
Commit-Queue: Clemens Hammacher <clemensh@chromium.org>
Reviewed-by: Michael Starzinger <mstarzinger@chromium.org>
Reviewed-by: Michael Achenbach <machenbach@chromium.org>
Cr-Commit-Position: refs/heads/master@{#60714}
This commit is contained in:
Clemens Hammacher 2019-04-09 15:00:38 +02:00 committed by Commit Bot
parent 7e896fe596
commit 31b49aeeb0
3 changed files with 9 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
test/webkit/webkit.status
View File

@ -109,10 +109,10 @@
}], # arch == arm64 and msan }], # arch == arm64 and msan
############################################################################## ##############################################################################
['variant in [no_liftoff, nooptimization, stress, stress_background_compile] and (arch == arm or arch == arm64) and simulator_run', { ['variant in [nooptimization, stress, stress_background_compile] and (arch == arm or arch == arm64) and simulator_run', {
# Slow tests: https://crbug.com/v8/7783 # Slow tests: https://crbug.com/v8/7783
'dfg-double-vote-fuzz': [SKIP], 'dfg-double-vote-fuzz': [SKIP],
}], # variant in [no_liftoff, nooptimization, stress, stress_background_compile] and (arch == arm or arch == arm64) and simulator_run }], # variant in [nooptimization, stress, stress_background_compile] and (arch == arm or arch == arm64) and simulator_run
############################################################################## ##############################################################################
['gcov_coverage', { ['gcov_coverage', {

9
tools/testrunner/local/variants.py
View File

@ -12,14 +12,17 @@ ALL_VARIANT_FLAGS = {
"infra_staging": [[]], "infra_staging": [[]],
"interpreted_regexp": [["--regexp-interpret-all"]], "interpreted_regexp": [["--regexp-interpret-all"]],
"jitless": [["--jitless"]], "jitless": [["--jitless"]],
"no_liftoff": [["--no-wasm-tier-up"]],
"minor_mc": [["--minor-mc"]], "minor_mc": [["--minor-mc"]],
# No optimization means disable all optimizations. OptimizeFunctionOnNextCall # No optimization means disable all optimizations. OptimizeFunctionOnNextCall
# would not force optimization too. It turns into a Nop. Please see # would not force optimization too. It turns into a Nop. Please see
# https://chromium-review.googlesource.com/c/452620/ for more discussion. # https://chromium-review.googlesource.com/c/452620/ for more discussion.
"nooptimization": [["--noopt"]], # For WebAssembly, we test "Liftoff-only" in the nooptimization variant and
# "TurboFan-only" in the stress variant. The WebAssembly configuration is
# independent of JS optimizations, so we can combine those configs.
"nooptimization": [["--no-opt", "--liftoff", "--no-wasm-tier-up"]],
"slow_path": [["--force-slow-path"]], "slow_path": [["--force-slow-path"]],
"stress": [["--stress-opt", "--always-opt"]], "stress": [["--stress-opt", "--always-opt", "--no-liftoff",
"--no-wasm-tier-up"]],
"stress_background_compile": [["--stress-background-compile"]], "stress_background_compile": [["--stress-background-compile"]],
"stress_incremental_marking": [["--stress-incremental-marking"]], "stress_incremental_marking": [["--stress-incremental-marking"]],
# Trigger stress sampling allocation profiler with sample interval = 2^14 # Trigger stress sampling allocation profiler with sample interval = 2^14

2
tools/testrunner/standard_runner.py
View File

@ -46,7 +46,7 @@ VARIANT_ALIASES = {
# Shortcut for the two above ("more" first - it has the longer running tests). # Shortcut for the two above ("more" first - it has the longer running tests).
"exhaustive": MORE_VARIANTS + VARIANTS, "exhaustive": MORE_VARIANTS + VARIANTS,
# Additional variants, run on a subset of bots. # Additional variants, run on a subset of bots.
"extra": ["nooptimization", "future", "no_liftoff", "no_wasm_traps"], "extra": ["nooptimization", "future", "no_wasm_traps"],
} }
GC_STRESS_FLAGS = ["--gc-interval=500", "--stress-compaction", GC_STRESS_FLAGS = ["--gc-interval=500", "--stress-compaction",