AuroraMiddleware/v8
1
0
Fork 0
Code Issues 2 Pull Requests Releases Wiki Activity

[test] Move cctest/test-api-icu to unittests/

Browse Source 
... api/api-icu-unittest.

Bug: v8:12781
Change-Id: Ibfc420e9d5ff0fce67f710b89a214332c7be65cc
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3748164
Reviewed-by: Leszek Swirski <leszeks@chromium.org>
Commit-Queue: 王澳 <wangao.james@bytedance.com>
Cr-Commit-Position: refs/heads/main@{#81883}
This commit is contained in:
jameslahm 2022-07-22 15:35:35 +08:00 committed by V8 LUCI CQ
parent fec831ded3
commit 323ce8bfd2
4 changed files with 57 additions and 58 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
test/cctest/BUILD.gn
View File

@ -167,7 +167,6 @@ v8_source_set("cctest_sources") {
"test-accessors.cc",
"test-allocation.cc",
"test-api-array-buffer.cc",
"test-api-icu.cc",
"test-api-interceptors.cc",
"test-api-stack-traces.cc",
"test-api-typed-array.cc",

57
test/cctest/test-api-icu.cc
View File

@ -1,57 +0,0 @@
// Copyright 2020 the V8 project authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
#ifdef V8_INTL_SUPPORT
#include <stdlib.h>
#include "include/v8-isolate.h"
#include "include/v8-local-handle.h"
#include "test/cctest/cctest.h"
#include "unicode/locid.h"
namespace {
void CheckLocaleSpecificValues(const char* locale, const char* date,
const char* number) {
CHECK(v8_str(locale)->StrictEquals(
CompileRun("Intl.NumberFormat().resolvedOptions().locale")));
CHECK(v8_str(date)->StrictEquals(
CompileRun("new Date('02/14/2020 13:45').toLocaleString()")));
CHECK(v8_str(number)->StrictEquals(
CompileRun("Number(10000.3).toLocaleString()")));
}
void SetIcuLocale(const char* locale_name) {
UErrorCode error_code = U_ZERO_ERROR;
icu::Locale locale(locale_name);
icu::Locale::setDefault(locale, error_code);
CHECK(U_SUCCESS(error_code));
}
} // namespace
TEST(LocaleConfigurationChangeNotification) {
icu::Locale default_locale = icu::Locale::getDefault();
LocalContext context;
v8::Isolate* isolate = context->GetIsolate();
v8::HandleScope scope(isolate);
SetIcuLocale("en_US");
isolate->LocaleConfigurationChangeNotification();
CheckLocaleSpecificValues("en-US", "2/14/2020, 1:45:00 PM", "10,000.3");
SetIcuLocale("ru_RU");
isolate->LocaleConfigurationChangeNotification();
CheckLocaleSpecificValues("ru-RU", "14.02.2020, 13:45:00", "10 000,3");
SetIcuLocale("zh_CN");
isolate->LocaleConfigurationChangeNotification();
CheckLocaleSpecificValues("zh-CN", "2020/2/14 13:45:00", "10,000.3");
UErrorCode error_code = U_ZERO_ERROR;
icu::Locale::setDefault(default_locale, error_code);
CHECK(U_SUCCESS(error_code));
}
#endif // V8_INTL_SUPPORT

1
test/unittests/BUILD.gn
View File

@ -224,6 +224,7 @@ v8_source_set("unittests_sources") {
"../../testing/gtest-support.h",
"api/access-check-unittest.cc",
"api/accessor-unittest.cc",
"api/api-icu-unittest.cc",
"api/deserialize-unittest.cc",
"api/exception-unittest.cc",
"api/interceptor-unittest.cc",

56
test/unittests/api/api-icu-unittest.cc Normal file
View File

@ -0,0 +1,56 @@
// Copyright 2020 the V8 project authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
#ifdef V8_INTL_SUPPORT
#include <stdlib.h>
#include "include/v8-isolate.h"
#include "include/v8-local-handle.h"
#include "src/objects/objects-inl.h"
#include "test/unittests/test-utils.h"
#include "testing/gtest/include/gtest/gtest.h"
#include "unicode/locid.h"
class ApiIcuTest : public v8::TestWithContext {
public:
void CheckLocaleSpecificValues(const char* locale, const char* date,
const char* number) {
CHECK(NewString(locale)->StrictEquals(
RunJS("Intl.NumberFormat().resolvedOptions().locale")));
CHECK(NewString(date)->StrictEquals(
RunJS("new Date('02/14/2020 13:45').toLocaleString()")));
CHECK(NewString(number)->StrictEquals(
RunJS("Number(10000.3).toLocaleString()")));
}
void SetIcuLocale(const char* locale_name) {
UErrorCode error_code = U_ZERO_ERROR;
icu::Locale locale(locale_name);
icu::Locale::setDefault(locale, error_code);
CHECK(U_SUCCESS(error_code));
}
};
TEST_F(ApiIcuTest, LocaleConfigurationChangeNotification) {
icu::Locale default_locale = icu::Locale::getDefault();
SetIcuLocale("en_US");
isolate()->LocaleConfigurationChangeNotification();
CheckLocaleSpecificValues("en-US", "2/14/2020, 1:45:00 PM", "10,000.3");
SetIcuLocale("ru_RU");
isolate()->LocaleConfigurationChangeNotification();
CheckLocaleSpecificValues("ru-RU", "14.02.2020, 13:45:00", "10 000,3");
SetIcuLocale("zh_CN");
isolate()->LocaleConfigurationChangeNotification();
CheckLocaleSpecificValues("zh-CN", "2020/2/14 13:45:00", "10,000.3");
UErrorCode error_code = U_ZERO_ERROR;
icu::Locale::setDefault(default_locale, error_code);
CHECK(U_SUCCESS(error_code));
}
#endif // V8_INTL_SUPPORT