AuroraMiddleware/v8
1
0
Fork 0
Code Issues 2 Pull Requests Releases Wiki Activity

[test] Guard a few CHECKs against --fuzzing

Browse Source 
Bug: chromium:1342305, chromium:1354926, chromium:1359709
Change-Id: I5ddedea227669908710b83f808cfb7c4718f0699
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3904608
Reviewed-by: Camillo Bruni <cbruni@chromium.org>
Commit-Queue: Maya Lekova <mslekova@chromium.org>
Cr-Commit-Position: refs/heads/main@{#83326}
This commit is contained in:
Maya Lekova 2022-09-19 17:19:31 +02:00 committed by V8 LUCI CQ
parent 75b12011b0
commit 332604d14b
1 changed files with 14 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
src/d8/d8-test.cc
View File

@ -669,10 +669,12 @@ class FastCApiObject {
CHECK_NOT_NULL(self);
self->fast_call_count_++;
// Number is in range.
CHECK(in_range && "Number range should have been enforced");
if (!std::isnan(real_arg)) {
CHECK_EQ(static_cast<IntegerT>(real_arg), checked_arg);
if (!i::v8_flags.fuzzing) {
// Number is in range.
CHECK(in_range && "Number range should have been enforced");
if (!std::isnan(real_arg)) {
CHECK_EQ(static_cast<IntegerT>(real_arg), checked_arg);
}
}
return true;
}
@ -688,6 +690,10 @@ class FastCApiObject {
HandleScope handle_scope(isolate);
if (i::v8_flags.fuzzing) {
args.GetReturnValue().Set(Boolean::New(isolate, false));
return;
}
double real_arg = 0;
if (args.Length() > 1 && args[1]->IsNumber()) {
real_arg = args[1]->NumberValue(isolate->GetCurrentContext()).FromJust();
@ -776,6 +782,10 @@ class FastCApiObject {
CHECK_SELF_OR_FALLBACK(false);
self->fast_call_count_++;
if (i::v8_flags.fuzzing) {
return true;
}
CHECK_NOT_NULL(options.wasm_memory);
uint8_t* memory = nullptr;
CHECK(options.wasm_memory->getStorageIfAligned(&memory));