AuroraMiddleware/v8
1
0
Fork 0
Code Issues 2 Pull Requests Releases Wiki Activity

[temporal] Use const ref consistently for std::vector arguments

Browse Source 
Change-Id: I7ecdfa6ee865d87851bf1975ddd48bd0bfcd39ba
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3805822
Reviewed-by: Frank Tang <ftang@chromium.org>
Commit-Queue: Adam Klein <adamk@chromium.org>
Cr-Commit-Position: refs/heads/main@{#82410}
This commit is contained in:
Adam Klein 2022-08-02 09:43:04 -07:00 committed by V8 LUCI CQ
parent cf765fc348
commit 338869fc03
2 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/objects/option-utils.cc
View File

@ -47,7 +47,7 @@ MaybeHandle<JSReceiver> CoerceOptionsToObject(Isolate* isolate,
Maybe<bool> GetStringOption(Isolate* isolate, Handle<JSReceiver> options, Maybe<bool> GetStringOption(Isolate* isolate, Handle<JSReceiver> options,
const char* property, const char* property,
std::vector<const char*> values, const std::vector<const char*>& values,
const char* method_name, const char* method_name,
std::unique_ptr<char[]>* result) { std::unique_ptr<char[]>* result) {
Handle<String> property_str = Handle<String> property_str =

2
src/objects/option-utils.h
View File

@ -36,7 +36,7 @@ V8_WARN_UNUSED_RESULT MaybeHandle<JSReceiver> CoerceOptionsToObject(
// printing the error message. // printing the error message.
V8_EXPORT_PRIVATE V8_WARN_UNUSED_RESULT Maybe<bool> GetStringOption( V8_EXPORT_PRIVATE V8_WARN_UNUSED_RESULT Maybe<bool> GetStringOption(
Isolate* isolate, Handle<JSReceiver> options, const char* property, Isolate* isolate, Handle<JSReceiver> options, const char* property,
std::vector<const char*> values, const char* method_name, const std::vector<const char*>& values, const char* method_name,
std::unique_ptr<char[]>* result); std::unique_ptr<char[]>* result);
// A helper template to get string from option into a enum. // A helper template to get string from option into a enum.