AuroraMiddleware/v8
1
0
Fork 0
Code Issues 2 Pull Requests Releases Wiki Activity

Annotate runtime call stats with trace events

Browse Source 
I used a new category "v8.runtime" and all events are disabled by
default, so there shouldn't be any perf impact.

BUG=none
R=fmeawad@chromium.org,cbruni@chromium.org

Review URL: https://codereview.chromium.org/1770353002

Cr-Commit-Position: refs/heads/master@{#34620}
This commit is contained in:
jochen 2016-03-09 05:09:24 -08:00 committed by Commit bot
parent 6975f77b4d
commit 34a47649e8
3 changed files with 8 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/arguments.h
View File

@ -7,6 +7,7 @@
#include "src/allocation.h" #include "src/allocation.h"
#include "src/isolate.h" #include "src/isolate.h"
#include "src/tracing/trace-event.h"
namespace v8 { namespace v8 {
namespace internal { namespace internal {
@ -277,6 +278,7 @@ double ClobberDoubleRegisters(double x1, double x2, double x3, double x4);
CLOBBER_DOUBLE_REGISTERS(); \ CLOBBER_DOUBLE_REGISTERS(); \
Arguments args(args_length, args_object); \ Arguments args(args_length, args_object); \
Type value; \ Type value; \
TRACE_EVENT0(TRACE_DISABLED_BY_DEFAULT("v8.runtime"), "V8." #Name); \
if (FLAG_runtime_call_stats) { \ if (FLAG_runtime_call_stats) { \
RuntimeCallStats* stats = isolate->counters()->runtime_call_stats(); \ RuntimeCallStats* stats = isolate->counters()->runtime_call_stats(); \
RuntimeCallTimerScope timer(isolate, &stats->Name); \ RuntimeCallTimerScope timer(isolate, &stats->Name); \

2
src/builtins.cc
View File

@ -145,6 +145,8 @@ BUILTIN_LIST_C(DEF_ARG_TYPE)
isolate->counters()->runtime_calls()->Increment(); \ isolate->counters()->runtime_calls()->Increment(); \
RuntimeCallStats* stats = isolate->counters()->runtime_call_stats(); \ RuntimeCallStats* stats = isolate->counters()->runtime_call_stats(); \
RuntimeCallTimerScope timer(isolate, &stats->Builtin_##name); \ RuntimeCallTimerScope timer(isolate, &stats->Builtin_##name); \
TRACE_EVENT0(TRACE_DISABLED_BY_DEFAULT("v8.runtime"), \
"V8.Builtin_" #name); \
name##ArgumentsType args(args_length, args_object); \ name##ArgumentsType args(args_length, args_object); \
Object* value = Builtin_Impl_##name(args, isolate); \ Object* value = Builtin_Impl_##name(args, isolate); \
return value; \ return value; \

4
src/vm-state-inl.h
View File

@ -68,6 +68,8 @@ ExternalCallbackScope::ExternalCallbackScope(Isolate* isolate, Address callback)
timer_.Initialize(&stats->ExternalCallback, stats->current_timer()); timer_.Initialize(&stats->ExternalCallback, stats->current_timer());
stats->Enter(&timer_); stats->Enter(&timer_);
} }
TRACE_EVENT_BEGIN0(TRACE_DISABLED_BY_DEFAULT("v8.runtime"),
"V8.ExternalCallback");
} }
ExternalCallbackScope::~ExternalCallbackScope() { ExternalCallbackScope::~ExternalCallbackScope() {
@ -75,6 +77,8 @@ ExternalCallbackScope::~ExternalCallbackScope() {
isolate_->counters()->runtime_call_stats()->Leave(&timer_); isolate_->counters()->runtime_call_stats()->Leave(&timer_);
} }
isolate_->set_external_callback_scope(previous_scope_); isolate_->set_external_callback_scope(previous_scope_);
TRACE_EVENT_END0(TRACE_DISABLED_BY_DEFAULT("v8.runtime"),
"V8.ExternalCallback");
} }
Address ExternalCallbackScope::scope_address() { Address ExternalCallbackScope::scope_address() {