Landing for hans@chromium.org.
TYPE_CHECK in v8.h should assign to volatile qualified null-pointer. Unless the pointer is volatile qualified, Clang will warn that LLVM removes the assignment during optimization. This is not a problem as that code should never execute, but the warning is treated as an error when building Chromium, and thus stops the build. Code review URL: http://codereview.chromium.org/3005010/show git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5093 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
This commit is contained in:
parent
aec9ce891e
commit
35a80e1624
@ -146,9 +146,9 @@ typedef void (*WeakReferenceCallback)(Persistent<Value> object,
|
||||
|
||||
// --- H a n d l e s ---
|
||||
|
||||
#define TYPE_CHECK(T, S) \
|
||||
while (false) { \
|
||||
*(static_cast<T**>(0)) = static_cast<S*>(0); \
|
||||
#define TYPE_CHECK(T, S) \
|
||||
while (false) { \
|
||||
*(static_cast<T* volatile*>(0)) = static_cast<S*>(0); \
|
||||
}
|
||||
|
||||
/**
|
||||
|
Loading…
Reference in New Issue
Block a user