AuroraMiddleware/v8
1
0
Fork 0
Code Issues 2 Pull Requests Releases Wiki Activity

[asmjs][cleanup] DCHECK that experimental opcodes are not used

Browse Source 
The wasm code for asm.js modules is generated by us and does not come
from the user. Therefore we do not need to check in release builds that
experimental opcodes are not used for asm.js, a DCHECK is sufficient.

R=clemensh@chromium.org

Change-Id: I0c7135bfb03eafd2a39e648d57eff8e3a4440c3f
Reviewed-on: https://chromium-review.googlesource.com/659938
Reviewed-by: Clemens Hammacher <clemensh@chromium.org>
Commit-Queue: Andreas Haas <ahaas@chromium.org>
Cr-Commit-Position: refs/heads/master@{#47950}
This commit is contained in:
Andreas Haas 2017-09-11 13:27:41 +02:00 committed by Commit Bot
parent 872d671307
commit 35be2798fb
1 changed files with 1 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/wasm/function-body-decoder-impl.h
View File

@ -40,9 +40,7 @@ struct WasmException;
}())
#define CHECK_PROTOTYPE_OPCODE(flag) \
if (this->module_ != nullptr && this->module_->is_asm_js()) { \
this->error("Opcode not supported for asmjs modules"); \
} \
DCHECK(!this->module_ || !this->module_->is_asm_js()); \
if (!FLAG_experimental_wasm_##flag) { \
this->error("Invalid opcode (enable with --experimental-wasm-" #flag ")"); \
break; \