AuroraMiddleware/v8
1
0
Fork 0
Code Issues 2 Pull Requests Releases Wiki Activity

[compiler] Remove bad "no cache reason" DCHECK

Browse Source 
The API doesn't forbid passing in a "no cache reason" even when there's
a cache.

Change-Id: I4392bd9707333e8bc39129de72de753d88265c5c
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3099950
Reviewed-by: Camillo Bruni <cbruni@chromium.org>
Commit-Queue: Leszek Swirski <leszeks@chromium.org>
Cr-Commit-Position: refs/heads/master@{#76347}
This commit is contained in:
Leszek Swirski 2021-08-17 17:12:54 +02:00 committed by V8 LUCI CQ
parent 831dd7c34a
commit 366b97a5e7
1 changed files with 0 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
src/api/api.cc
View File

@ -2429,7 +2429,6 @@ MaybeLocal<UnboundScript> ScriptCompiler::CompileUnboundInternal(
i::MaybeHandle<i::SharedFunctionInfo> maybe_function_info;
if (options == kConsumeCodeCache) {
DCHECK_EQ(no_cache_reason, NoCacheReason::kNoCacheNoReason);
if (source->consume_cache_task) {
// Take ownership of the internal deserialization task and clear it off
// the consume task on the source.