AuroraMiddleware/v8
1
0
Fork 0
Code Issues 2 Pull Requests Releases Wiki Activity

Replace old CHECKs by DCHECKs in HandleApiCall

Browse Source 
HandleApiCall is one of the most heavily used builtins on Node.js.
Replace some old CHECKs with DCHECKs.

R=ishell@chromium.org, jochen@chromium.org
BUG=

Review URL: https://codereview.chromium.org/1804433005

Cr-Commit-Position: refs/heads/master@{#34758}
This commit is contained in:
ofrobots 2016-03-14 10:59:30 -07:00 committed by Commit bot
parent ad91d1c6ca
commit 36f6f5e1aa
1 changed files with 4 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
src/builtins.cc
View File

@ -3908,9 +3908,9 @@ MUST_USE_RESULT MaybeHandle<Object> HandleApiCallHelper(
HandleScope scope(isolate);
Handle<HeapObject> function = args.target<HeapObject>();
Handle<JSReceiver> receiver;
// TODO(ishell): turn this back to a DCHECK.
CHECK(function->IsFunctionTemplateInfo() ||
Handle<JSFunction>::cast(function)->shared()->IsApiFunction());
DCHECK(function->IsFunctionTemplateInfo() ||
Handle<JSFunction>::cast(function)->shared()->IsApiFunction());
Handle<FunctionTemplateInfo> fun_data =
function->IsFunctionTemplateInfo()
@ -3956,8 +3956,7 @@ MUST_USE_RESULT MaybeHandle<Object> HandleApiCallHelper(
Object* raw_call_data = fun_data->call_code();
if (!raw_call_data->IsUndefined()) {
// TODO(ishell): remove this debugging code.
CHECK(raw_call_data->IsCallHandlerInfo());
DCHECK(raw_call_data->IsCallHandlerInfo());
CallHandlerInfo* call_data = CallHandlerInfo::cast(raw_call_data);
Object* callback_obj = call_data->callback();
v8::FunctionCallback callback =