AuroraMiddleware/v8
1
0
Fork 0
Code Issues 2 Pull Requests Releases Wiki Activity

[ubsan] Blacklist reports for *CallbackInfo

Browse Source 
Both PropertyCallbackInfo<T> and WeakCallbackInfo<T> callbacks are
using a design that relies on invalid reinterpret_casts and thereby
undefined behavior. Since they are exposed via the public API, fixing
this is going to be difficult.

Bug: v8:3770,v8:8735
Change-Id: I7171c5b38f070b4a43a0de1ebb7d1a1458c1d91f
Reviewed-on: https://chromium-review.googlesource.com/c/1436222
Reviewed-by: Adam Klein <adamk@chromium.org>
Commit-Queue: Jakob Kummerow <jkummerow@chromium.org>
Cr-Commit-Position: refs/heads/master@{#59083}
This commit is contained in:
Jakob Kummerow 2019-01-24 17:23:32 -08:00 committed by Commit Bot
parent bdf8780f3d
commit 373f9d3212
1 changed files with 9 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
tools/ubsan/blacklist.txt
View File

@ -4,3 +4,12 @@
# UBSan bug, fixed in LLVM r350779. Drop this suppression when that
# revision has rolled into Chromium's bundled Clang.
fun:*v8*internal*NewArray*
# Bug 8735: PropertyCallbackInfo<void> vs PropertyCallbackInfo<T>.
fun:*v8*internal*PropertyCallbackArguments*CallAccessorSetter*
fun:*v8*internal*PropertyCallbackArguments*BasicCallNamedGetterCallback*
fun:*v8*internal*InvokeAccessorGetterCallback*
# Bug 8735: WeakCallbackInfo<void> vs. WeakCallbackInfo<T>.
fun:*v8*internal*GlobalHandles*PendingPhantomCallback*Invoke*
fun:*v8*internal*GlobalHandles*Node*PostGarbageCollectionProcessing*