AuroraMiddleware/v8
1
0
Fork 0
Code Issues 2 Pull Requests Releases Wiki Activity

Revert "[wasm] Enable --wasm-shared-engine by default."

Browse Source 
This reverts commit c5c447d449.

Reason for revert: Race condition
https://ci.chromium.org/p/v8/builders/luci.v8.ci/V8%20Linux/26284

Original change's description:
> [wasm] Enable --wasm-shared-engine by default.
> 
> R=​titzer@chromium.org
> BUG=v8:7424
> 
> Change-Id: I3bb3be92b6c1bf855904cf0bf334ad98dce74dd4
> Reviewed-on: https://chromium-review.googlesource.com/1156310
> Reviewed-by: Ben Titzer <titzer@chromium.org>
> Commit-Queue: Michael Starzinger <mstarzinger@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#54855}

TBR=mstarzinger@chromium.org,titzer@chromium.org

Change-Id: I46b00693b087af0076c634480c15ab109dcbbcce
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: v8:7424
Reviewed-on: https://chromium-review.googlesource.com/1160241
Reviewed-by: Sigurd Schneider <sigurds@chromium.org>
Commit-Queue: Sigurd Schneider <sigurds@chromium.org>
Cr-Commit-Position: refs/heads/master@{#54856}
This commit is contained in:
Sigurd Schneider 2018-08-02 08:46:29 +00:00 committed by Commit Bot
parent c5c447d449
commit 37dfedea6f
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/flag-definitions.h
View File

@ -614,7 +614,7 @@ DEFINE_BOOL(wasm_no_bounds_checks, false,
DEFINE_BOOL(wasm_no_stack_checks, false,
"disable stack checks (performance testing only)")
DEFINE_BOOL(wasm_shared_engine, true,
DEFINE_BOOL(wasm_shared_engine, false,
"shares one wasm engine between all isolates within a process")
DEFINE_IMPLICATION(future, wasm_shared_engine)
DEFINE_BOOL(wasm_shared_code, false,