AuroraMiddleware/v8
1
0
Fork 0
Code Issues 2 Pull Requests Releases Wiki Activity

Revert "[nojit] Don't flush the icache in jitless mode"

Browse Source 
This reverts commit 71d29f7892.

Reason for revert: Needs test skips https://ci.chromium.org/p/v8/builders/luci.v8.ci/V8%20Arm/9744

Original change's description:
> [nojit] Don't flush the icache in jitless mode
> 
> We don't allocate executable memory in jitless mode hence there's no
> need to flush the icache.
> 
> Bug: v8:7777
> Change-Id: I70a1884e6c9f11405465f5741f2eccd4f7a273fb
> Reviewed-on: https://chromium-review.googlesource.com/c/1488765
> Commit-Queue: Jakob Gruber <jgruber@chromium.org>
> Reviewed-by: Sigurd Schneider <sigurds@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#59887}

TBR=sigurds@chromium.org,jgruber@chromium.org

Change-Id: I548bcbbd5c6df542dd647b8bbb8accae62e197e6
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: v8:7777
Reviewed-on: https://chromium-review.googlesource.com/c/1491600
Reviewed-by: Jakob Gruber <jgruber@chromium.org>
Commit-Queue: Jakob Gruber <jgruber@chromium.org>
Cr-Commit-Position: refs/heads/master@{#59908}
This commit is contained in:
Jakob Gruber 2019-02-27 15:03:23 +00:00 committed by Commit Bot
parent 12a69b70a2
commit 3852a9d199
1 changed files with 0 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
src/flush-instruction-cache.cc
View File

@ -13,7 +13,6 @@ namespace internal {
void FlushInstructionCache(void* start, size_t size) {
if (size == 0) return;
if (FLAG_jitless) return; // There's no executable memory to flush.
#if defined(USE_SIMULATOR)
base::MutexGuard lock_guard(Simulator::i_cache_mutex());