AuroraMiddleware/v8
1
0
Fork 0
Code Issues 2 Pull Requests Releases Wiki Activity

Revert "[Jank]: Add uri trace events"

Browse Source 
This reverts commit d1aee56d1a.

Reason for revert: Trace event is causing telemetry regressions
(crbug.com/1094957).
I got a few days of traces and didn't really find what I was looking for, so I'll find another way to investigate.

Original change's description:
> [Jank]: Add uri trace events
> 
> To investigate jank found in UMA sampling profiler.
> 
> Bug: chromium:1081433
> Change-Id: I457731380505af5a4d7a0c30d01b4049ffd2b436
> Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2242037
> Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org>
> Reviewed-by: Leszek Swirski <leszeks@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#68326}

TBR=leszeks@chromium.org,etiennep@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: chromium:1081433, chromium:1094957
Change-Id: I6c9573e9a77a54255c5fadc3cec14d437fd62b45
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2279135
Auto-Submit: Etienne Pierre-Doray <etiennep@chromium.org>
Reviewed-by: Leszek Swirski <leszeks@chromium.org>
Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org>
Cr-Commit-Position: refs/heads/master@{#68949}
This commit is contained in:
Etienne Pierre-Doray 2020-07-02 15:04:54 +00:00 committed by Commit Bot
parent 8228c06e9f
commit 3883b29a75
1 changed files with 0 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
src/strings/uri.cc
View File

@ -10,7 +10,6 @@
#include "src/strings/char-predicates-inl.h"
#include "src/strings/string-search.h"
#include "src/strings/unicode-inl.h"
#include "src/tracing/trace-event.h"
namespace v8 {
namespace internal {
@ -175,8 +174,6 @@ bool IntoOneAndTwoByte(Handle<String> uri, bool is_uri,
MaybeHandle<String> Uri::Decode(Isolate* isolate, Handle<String> uri,
bool is_uri) {
TRACE_EVENT0("v8", "V8.DecodeUri");
uri = String::Flatten(isolate, uri);
std::vector<uint8_t> one_byte_buffer;
std::vector<uc16> two_byte_buffer;
@ -281,8 +278,6 @@ void EncodePair(uc16 cc1, uc16 cc2, std::vector<uint8_t>* buffer) {
MaybeHandle<String> Uri::Encode(Isolate* isolate, Handle<String> uri,
bool is_uri) {
TRACE_EVENT0("v8", "V8.EncodeUri");
uri = String::Flatten(isolate, uri);
int uri_length = uri->length();
std::vector<uint8_t> buffer;