AuroraMiddleware/v8
1
0
Fork 0
Code Issues 2 Pull Requests Releases Wiki Activity

Fix issue 1076 by resetting labels of switch-clauses before use.

Browse Source 
If we compile a function literal twice with the full code generator,
we must make sure that the labels embedded in the AST are reset.

BUG=1076

Review URL: http://codereview.chromium.org/6339014

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@6496 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
This commit is contained in:
fschneider@chromium.org 2011-01-26 15:28:17 +00:00
parent eb3970c822
commit 38b91a4ffe
3 changed files with 6 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/arm/full-codegen-arm.cc
View File

@ -734,6 +734,8 @@ void FullCodeGenerator::VisitSwitchStatement(SwitchStatement* stmt) {
// Compile all the tests with branches to their bodies. // Compile all the tests with branches to their bodies.
for (int i = 0; i < clauses->length(); i++) { for (int i = 0; i < clauses->length(); i++) {
CaseClause* clause = clauses->at(i); CaseClause* clause = clauses->at(i);
clause->body_target()->entry_label()->Unuse();
// The default is not a test, but remember it as final fall through. // The default is not a test, but remember it as final fall through.
if (clause->is_default()) { if (clause->is_default()) {
default_clause = clause; default_clause = clause;

2
src/ia32/full-codegen-ia32.cc
View File

@ -764,6 +764,8 @@ void FullCodeGenerator::VisitSwitchStatement(SwitchStatement* stmt) {
// Compile all the tests with branches to their bodies. // Compile all the tests with branches to their bodies.
for (int i = 0; i < clauses->length(); i++) { for (int i = 0; i < clauses->length(); i++) {
CaseClause* clause = clauses->at(i); CaseClause* clause = clauses->at(i);
clause->body_target()->entry_label()->Unuse();
// The default is not a test, but remember it as final fall through. // The default is not a test, but remember it as final fall through.
if (clause->is_default()) { if (clause->is_default()) {
default_clause = clause; default_clause = clause;

2
src/x64/full-codegen-x64.cc
View File

@ -710,6 +710,8 @@ void FullCodeGenerator::VisitSwitchStatement(SwitchStatement* stmt) {
// Compile all the tests with branches to their bodies. // Compile all the tests with branches to their bodies.
for (int i = 0; i < clauses->length(); i++) { for (int i = 0; i < clauses->length(); i++) {
CaseClause* clause = clauses->at(i); CaseClause* clause = clauses->at(i);
clause->body_target()->entry_label()->Unuse();
// The default is not a test, but remember it as final fall through. // The default is not a test, but remember it as final fall through.
if (clause->is_default()) { if (clause->is_default()) {
default_clause = clause; default_clause = clause;