From 38c872aa6365f39fa75dbe3c5f54e987f6d64388 Mon Sep 17 00:00:00 2001 From: Mike Stanton Date: Mon, 21 Jun 2021 09:46:44 +0200 Subject: [PATCH] Concurrent stress mode adjustment in predictable test variant If a test specifies --stress-concurrent-inlining it shouldn't be run in predictable mode, since it is depending on some concurrent behavior (a race condition) between threads. Bug: v8:11907 Change-Id: I027eed056689a8ee62675fce7dfa0701d202e970 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2975298 Reviewed-by: Michael Achenbach Commit-Queue: Michael Stanton Cr-Commit-Position: refs/heads/master@{#75297} --- tools/testrunner/local/variants.py | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/tools/testrunner/local/variants.py b/tools/testrunner/local/variants.py index a8a856a06a..c8a8856929 100644 --- a/tools/testrunner/local/variants.py +++ b/tools/testrunner/local/variants.py @@ -81,7 +81,8 @@ INCOMPATIBLE_FLAGS_PER_BUILD_VARIABLE = { + INCOMPATIBLE_FLAGS_PER_VARIANT["jitless"], "predictable": ["--parallel-compile-tasks", "--concurrent-recompilation", - "--stress-concurrent-allocation"], + "--stress-concurrent-allocation", + "--stress-concurrent-inlining"], } # Flags that lead to a contradiction when a certain extra-flag is present.