AuroraMiddleware/v8
1
0
Fork 0
Code Issues 2 Pull Requests Releases Wiki Activity

[cleanup] Remove duplicate getter in Signature class

Browse Source 
R=tebbi@chromium.org

Bug: v8:7793, v8:8562
Change-Id: I783a6d76edd20b73b25cc81395ecadbedd346e8b
Reviewed-on: https://chromium-review.googlesource.com/c/1447775
Reviewed-by: Tobias Tebbi <tebbi@chromium.org>
Commit-Queue: Simon Zünd <szuend@chromium.org>
Cr-Commit-Position: refs/heads/master@{#59239}
This commit is contained in:
Simon Zünd 2019-01-31 11:58:07 +01:00 committed by Commit Bot
parent d3b5cbeaaa
commit 3974a6558e
2 changed files with 2 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/torque/types.cc
View File

@ -339,8 +339,8 @@ std::ostream& operator<<(std::ostream& os, const ParameterTypes& p) {
bool Signature::HasSameTypesAs(const Signature& other,
ParameterMode mode) const {
auto compare_types = GetTypes();
auto other_compare_types = other.GetTypes();
auto compare_types = types();
auto other_compare_types = other.types();
if (mode == ParameterMode::kIgnoreImplicit) {
compare_types = GetExplicitTypes();
other_compare_types = other.GetExplicitTypes();

1
src/torque/types.h
View File

@ -583,7 +583,6 @@ struct Signature {
bool HasSameTypesAs(
const Signature& other,
ParameterMode mode = ParameterMode::kProcessImplicit) const;
const TypeVector& GetTypes() const { return parameter_types.types; }
TypeVector GetImplicitTypes() const {
return TypeVector(parameter_types.types.begin(),
parameter_types.types.begin() + implicit_count);