AuroraMiddleware/v8
1
0
Fork 0
Code Issues 2 Pull Requests Releases Wiki Activity

[ast] Fix a comment about placeholder for computed property values

Browse Source 
R=mvstanton@chromium.org

Change-Id: Ia9b5b6e3b80334555faddd1fbc70995d414295a6
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2960889
Reviewed-by: Michael Stanton <mvstanton@chromium.org>
Commit-Queue: Georg Neis <neis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#75144}
This commit is contained in:
Georg Neis 2021-06-14 18:46:46 +02:00 committed by V8 LUCI CQ
parent 019d459299
commit 3a6ace557c
1 changed files with 3 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
src/ast/ast.cc
View File

@ -482,9 +482,9 @@ void ObjectLiteral::BuildBoilerplateDescription(IsolateT* isolate) {
m_literal->BuildConstants(isolate);
}
// Add CONSTANT and COMPUTED properties to boilerplate. Use undefined
// value for COMPUTED properties, the real value is filled in at
// runtime. The enumeration order is maintained.
// Add CONSTANT and COMPUTED properties to boilerplate. Use the
// 'uninitialized' Oddball for COMPUTED properties, the real value is filled
// in at runtime. The enumeration order is maintained.
Literal* key_literal = property->key()->AsLiteral();
uint32_t element_index = 0;
Handle<Object> key =
@ -493,10 +493,7 @@ void ObjectLiteral::BuildBoilerplateDescription(IsolateT* isolate) {
->template NewNumberFromUint<AllocationType::kOld>(
element_index)
: Handle<Object>::cast(key_literal->AsRawPropertyName()->string());
Handle<Object> value = GetBoilerplateValue(property->value(), isolate);
// Add name, value pair to the fixed array.
boilerplate_description->set_key_value(position++, *key, *value);
}