[cleanup][ptr-compr] Remove Decompressed Signed/Any register to register

Since the old pipeline has been removed
(https://chromium-review.googlesource.com/c/v8/v8/+/1903435), these
opcodes and methods are unused.

Bug: v8:7703
Change-Id: I626645a1405c79c6a202da6075fb64f0a2a41d25
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1921799
Commit-Queue: Santiago Aboy Solanes <solanes@chromium.org>
Reviewed-by: Tobias Tebbi <tebbi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#65066}
This commit is contained in:
Santiago Aboy Solanes 2019-11-20 12:50:34 +00:00 committed by Commit Bot
parent 7b3b82f04f
commit 3b0329abb1
10 changed files with 0 additions and 83 deletions

View File

@ -2652,18 +2652,6 @@ void TurboAssembler::DecompressTaggedSigned(const Register& destination,
RecordComment("]");
}
void TurboAssembler::DecompressTaggedSigned(const Register& destination,
const Register& source) {
RecordComment("[ DecompressTaggedSigned");
Mov(destination.W(), source.W());
if (FLAG_debug_code) {
// Corrupt the top 32 bits. Made up of 16 fixed bits and 16 pc offset bits.
Add(destination, destination,
((kDebugZapValue << 16) | (pc_offset() & 0xffff)) << 32);
}
RecordComment("]");
}
void TurboAssembler::DecompressTaggedPointer(const Register& destination,
const MemOperand& field_operand) {
RecordComment("[ DecompressTaggedPointer");
@ -2687,13 +2675,6 @@ void TurboAssembler::DecompressAnyTagged(const Register& destination,
RecordComment("]");
}
void TurboAssembler::DecompressAnyTagged(const Register& destination,
const Register& source) {
RecordComment("[ DecompressAnyTagged");
Add(destination, kRootRegister, Operand(source, UXTW));
RecordComment("]");
}
int MacroAssembler::SafepointRegisterStackIndex(int reg_code) {
// Make sure the safepoint registers list is what we expect.
DCHECK_EQ(CPURegList::GetSafepointSavedRegisters().list(), 0x6FFCFFFF);

View File

@ -1288,15 +1288,12 @@ class V8_EXPORT_PRIVATE TurboAssembler : public TurboAssemblerBase {
void DecompressTaggedSigned(const Register& destination,
const MemOperand& field_operand);
void DecompressTaggedSigned(const Register& destination,
const Register& source);
void DecompressTaggedPointer(const Register& destination,
const MemOperand& field_operand);
void DecompressTaggedPointer(const Register& destination,
const Register& source);
void DecompressAnyTagged(const Register& destination,
const MemOperand& field_operand);
void DecompressAnyTagged(const Register& destination, const Register& source);
protected:
// The actual Push and Pop implementations. These don't generate any code

View File

@ -281,13 +281,6 @@ void TurboAssembler::DecompressTaggedSigned(Register destination,
RecordComment("]");
}
void TurboAssembler::DecompressTaggedSigned(Register destination,
Register source) {
RecordComment("[ DecompressTaggedSigned");
movl(destination, source);
RecordComment("]");
}
void TurboAssembler::DecompressTaggedPointer(Register destination,
Operand field_operand) {
RecordComment("[ DecompressTaggedPointer");
@ -319,15 +312,6 @@ void TurboAssembler::DecompressAnyTagged(Register destination,
RecordComment("]");
}
void TurboAssembler::DecompressAnyTagged(Register destination, Register source,
Register scratch) {
DCHECK(!AreAliased(destination, scratch));
RecordComment("[ DecompressAnyTagged");
movl(destination, source);
DecompressRegisterAnyTagged(destination, scratch);
RecordComment("]");
}
void MacroAssembler::RecordWriteField(Register object, int offset,
Register value, Register dst,
SaveFPRegsMode save_fp,

View File

@ -577,7 +577,6 @@ class V8_EXPORT_PRIVATE TurboAssembler : public TurboAssemblerBase {
// The following macros work even when pointer compression is not enabled.
void DecompressTaggedSigned(Register destination, Operand field_operand);
void DecompressTaggedSigned(Register destination, Register source);
void DecompressTaggedPointer(Register destination, Operand field_operand);
void DecompressTaggedPointer(Register destination, Register source);
// Auxiliary function used by DecompressAnyTagged to perform the actual
@ -585,8 +584,6 @@ class V8_EXPORT_PRIVATE TurboAssembler : public TurboAssemblerBase {
void DecompressRegisterAnyTagged(Register destination, Register scratch);
void DecompressAnyTagged(Register destination, Operand field_operand,
Register scratch = kScratchRegister);
void DecompressAnyTagged(Register destination, Register source,
Register scratch = kScratchRegister);
protected:
static const int kSmiShift = kSmiTagSize + kSmiShiftSize;

View File

@ -1636,18 +1636,6 @@ CodeGenerator::CodeGenResult CodeGenerator::AssembleArchInstruction(
case kArm64StrCompressTagged:
__ StoreTaggedField(i.InputOrZeroRegister64(0), i.MemoryOperand(1));
break;
case kArm64DecompressSigned: {
__ DecompressTaggedSigned(i.OutputRegister(), i.InputRegister(0));
break;
}
case kArm64DecompressPointer: {
__ DecompressTaggedPointer(i.OutputRegister(), i.InputRegister(0));
break;
}
case kArm64DecompressAny: {
__ DecompressAnyTagged(i.OutputRegister(), i.InputRegister(0));
break;
}
case kArm64LdrS:
EmitMaybePoisonedFPLoad(this, opcode, &i, i.OutputDoubleRegister().S());
break;

View File

@ -166,9 +166,6 @@ namespace compiler {
V(Arm64LdrDecompressAnyTagged) \
V(Arm64Str) \
V(Arm64StrCompressTagged) \
V(Arm64DecompressSigned) \
V(Arm64DecompressPointer) \
V(Arm64DecompressAny) \
V(Arm64DmbIsh) \
V(Arm64DsbIsb) \
V(Arm64F64x2Splat) \

View File

@ -326,9 +326,6 @@ int InstructionScheduler::GetTargetInstructionFlags(
case kArm64TestAndBranch:
case kArm64CompareAndBranch32:
case kArm64CompareAndBranch:
case kArm64DecompressSigned:
case kArm64DecompressPointer:
case kArm64DecompressAny:
return kNoOpcodeFlags;
case kArm64LdrS:

View File

@ -2014,24 +2014,6 @@ CodeGenerator::CodeGenResult CodeGenerator::AssembleArchInstruction(
}
break;
}
case kX64DecompressSigned: {
CHECK(instr->HasOutput());
ASSEMBLE_MOVX(DecompressTaggedSigned);
EmitWordLoadPoisoningIfNeeded(this, opcode, instr, i);
break;
}
case kX64DecompressPointer: {
CHECK(instr->HasOutput());
ASSEMBLE_MOVX(DecompressTaggedPointer);
EmitWordLoadPoisoningIfNeeded(this, opcode, instr, i);
break;
}
case kX64DecompressAny: {
CHECK(instr->HasOutput());
ASSEMBLE_MOVX(DecompressAnyTagged);
EmitWordLoadPoisoningIfNeeded(this, opcode, instr, i);
break;
}
case kX64Movq:
EmitOOLTrapIfNeeded(zone(), this, opcode, instr, __ pc_offset());
if (instr->HasOutput()) {

View File

@ -137,9 +137,6 @@ namespace compiler {
V(X64MovqDecompressTaggedPointer) \
V(X64MovqDecompressAnyTagged) \
V(X64MovqCompressTagged) \
V(X64DecompressSigned) \
V(X64DecompressPointer) \
V(X64DecompressAny) \
V(X64Movq) \
V(X64Movsd) \
V(X64Movss) \

View File

@ -312,9 +312,6 @@ int InstructionScheduler::GetTargetInstructionFlags(
case kX64S8x2Reverse:
case kX64S1x16AnyTrue:
case kX64S1x16AllTrue:
case kX64DecompressSigned:
case kX64DecompressPointer:
case kX64DecompressAny:
return (instr->addressing_mode() == kMode_None)
? kNoOpcodeFlags
: kIsLoadOperation | kHasSideEffect;