AuroraMiddleware/v8
1
0
Fork 0
Code Issues 2 Pull Requests Releases Wiki Activity

cppgc: Fix unittests perfetto build.

Browse Source 
cppgc_unittests uses tracing (e.g. when setting the TracingController in
tests.h) and thus needs to depend on v8_tracing. It cannot inherit the
dependency since the cppgc_unittests_sources v8_source_set doesn't
depend on cppgc.

Bug: v8:11203
Change-Id: I7227f696f841132f174435751a42a02ff865df26
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2563658
Auto-Submit: Omer Katz <omerkatz@chromium.org>
Reviewed-by: Michael Lippautz <mlippautz@chromium.org>
Commit-Queue: Omer Katz <omerkatz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#71453}
This commit is contained in:
Omer Katz 2020-11-27 15:10:47 +01:00 committed by Commit Bot
parent 4f2f106206
commit 3b139bf8f4
1 changed files with 4 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
test/unittests/BUILD.gn
View File

@ -133,6 +133,10 @@ v8_source_set("cppgc_unittests_sources") {
"//testing/gmock",
"//testing/gtest",
]
if (!cppgc_is_standalone) {
deps += [ "../..:v8_tracing" ]
}
}
v8_executable("unittests") {