AuroraMiddleware/v8
1
0
Fork 0
Code Issues 2 Pull Requests Releases Wiki Activity

[turbofan] Remove a redundant condition

Browse Source 
R=bmeurer@chromium.org

Change-Id: Ibfe4a0f12eedd2b4d6a5614e99f2076c026aea24
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1557141
Reviewed-by: Benedikt Meurer <bmeurer@chromium.org>
Commit-Queue: Georg Neis <neis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#60674}
This commit is contained in:
Georg Neis 2019-04-08 11:18:18 +02:00 committed by Commit Bot
parent 2ead93fe27
commit 3b2aa862fe
1 changed files with 3 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/compiler/js-native-context-specialization.cc
View File

@ -1737,6 +1737,7 @@ Reduction JSNativeContextSpecialization::ReduceKeyedLoadFromHeapConstant(
if (receiver_ref.map().oddball_type() == OddballType::kHole ||
receiver_ref.map().oddball_type() == OddballType::kNull ||
receiver_ref.map().oddball_type() == OddballType::kUndefined ||
// The 'in' operator throws a TypeError on primitive values.
(receiver_ref.IsString() && access_mode == AccessMode::kHas)) {
return NoChange();
}
@ -1797,7 +1798,8 @@ Reduction JSNativeContextSpecialization::ReduceKeyedLoadFromHeapConstant(
// For constant Strings we can eagerly strength-reduce the keyed
// accesses using the known length, which doesn't change.
if (receiver_ref.IsString() && access_mode != AccessMode::kHas) {
if (receiver_ref.IsString()) {
DCHECK_NE(access_mode, AccessMode::kHas);
// We can only assume that the {index} is a valid array index if the
// IC is in element access mode and not MEGAMORPHIC, otherwise there's
// no guard for the bounds check below.