AuroraMiddleware/v8
1
0
Fork 0
Code Issues 2 Pull Requests Releases Wiki Activity

[turbofan] Remove some TODOs that no longer apply.

Browse Source 
R=bmeurer@chromium.org

Review-Url: https://codereview.chromium.org/2067513002
Cr-Commit-Position: refs/heads/master@{#36949}
This commit is contained in:
mstarzinger 2016-06-14 00:59:05 -07:00 committed by Commit bot
parent 3dbc7586fb
commit 3b2da29532
5 changed files with 3 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/compiler/access-info.cc
View File

@ -9,7 +9,7 @@
#include "src/compiler/access-info.h"
#include "src/field-index-inl.h"
#include "src/field-type.h"
#include "src/objects-inl.h" // TODO(mstarzinger): Temporary cycle breaker!
#include "src/objects-inl.h"
#include "src/type-cache.h"
namespace v8 {

3
src/compiler/ast-graph-builder.cc
View File

@ -281,8 +281,6 @@ class AstGraphBuilder::ControlScope::DeferredCommands : public ZoneObject {
return NewPathToken(TokenDispenserForFinally::kFallThroughToken);
}
Node* NewPathDispatchCondition(Node* t1, Node* t2) {
// TODO(mstarzinger): This should be machine()->WordEqual(), but our Phi
// nodes all have kRepTagged|kTypeAny, which causes representation mismatch.
return owner_->NewNode(owner_->javascript()->StrictEqual(), t1, t2);
}
@ -4305,7 +4303,6 @@ Node* AstGraphBuilder::NewPhi(int count, Node* input, Node* control) {
}
// TODO(mstarzinger): Revisit this once we have proper effect states.
Node* AstGraphBuilder::NewEffectPhi(int count, Node* input, Node* control) {
const Operator* phi_op = common()->EffectPhi(count);
Node** buffer = EnsureInputBufferSize(count + 1);

2
src/compiler/js-global-object-specialization.cc
View File

@ -12,7 +12,7 @@
#include "src/compiler/node-properties.h"
#include "src/compiler/simplified-operator.h"
#include "src/lookup.h"
#include "src/objects-inl.h" // TODO(mstarzinger): Temporary cycle breaker!
#include "src/objects-inl.h"
#include "src/type-cache.h"
namespace v8 {

1
src/compiler/js-native-context-specialization.cc
View File

@ -15,7 +15,6 @@
#include "src/compiler/node-matchers.h"
#include "src/field-index-inl.h"
#include "src/isolate-inl.h"
#include "src/objects-inl.h" // TODO(mstarzinger): Temporary cycle breaker!
#include "src/type-cache.h"
#include "src/type-feedback-vector.h"

3
src/wasm/wasm-result.cc
View File

@ -6,8 +6,7 @@
#include "src/factory.h"
#include "src/heap/heap.h"
#include "src/isolate.h"
#include "src/objects-inl.h" // TODO(mstarzinger): Temporary cycle breaker!
#include "src/isolate-inl.h"
#include "src/objects.h"
#include "src/base/platform/platform.h"