AuroraMiddleware/v8
1
0
Fork 0
Code Issues 2 Pull Requests Releases Wiki Activity

GCC: explicitely instantiate JSObject::ApplyAttributesToDictionary for NumberDictionary

Browse Source 
elements.cc invokes ApplyAttributesToDictionary using NumberDictionary as its template
parameter. But the declaration of the template method is in js-object.cc, so nobody
can actually compile the version for number dictionary. This is fixed requesting
explicit instantiation for NumberDictionary.

This was breaking GCC build.

Bug: chromium:819294
Change-Id: I685ddc5b97e129d1a534dbdb04025c0932bc5ecd
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1649565
Reviewed-by: Toon Verwaest <verwaest@chromium.org>
Commit-Queue: José Dapena Paz <jose.dapena@lge.com>
Cr-Commit-Position: refs/heads/master@{#62097}
This commit is contained in:
Jose Dapena Paz 2019-06-07 19:56:59 +02:00 committed by Commit Bot
parent bf3202c8b8
commit 3b8c624bda
2 changed files with 5 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
AUTHORS
View File

@ -15,6 +15,7 @@ NVIDIA Corporation <*@nvidia.com>
BlackBerry Limited <*@blackberry.com> BlackBerry Limited <*@blackberry.com>
Opera Software ASA <*@opera.com> Opera Software ASA <*@opera.com>
Intel Corporation <*@intel.com> Intel Corporation <*@intel.com>
LG Electronics, Inc. <*@lge.com>
Microsoft <*@microsoft.com> Microsoft <*@microsoft.com>
MIPS Technologies, Inc. <*@mips.com> MIPS Technologies, Inc. <*@mips.com>
Imagination Technologies, LLC <*@imgtec.com> Imagination Technologies, LLC <*@imgtec.com>

4
src/objects/js-objects.cc
View File

@ -3753,6 +3753,10 @@ void JSObject::ApplyAttributesToDictionary(
} }
} }
template void JSObject::ApplyAttributesToDictionary(
Isolate* isolate, ReadOnlyRoots roots, Handle<NumberDictionary> dictionary,
const PropertyAttributes attributes);
template <PropertyAttributes attrs> template <PropertyAttributes attrs>
Maybe<bool> JSObject::PreventExtensionsWithTransition( Maybe<bool> JSObject::PreventExtensionsWithTransition(
Handle<JSObject> object, ShouldThrow should_throw) { Handle<JSObject> object, ShouldThrow should_throw) {