AuroraMiddleware/v8
1
0
Fork 0
Code Issues 2 Pull Requests Releases Wiki Activity

Setting the thread name may fail, so don't assert that the result is 0.

Browse Source 
R=yangguo@chromium.org

Review URL: https://codereview.chromium.org/20216003

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@15868 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
This commit is contained in:
bmeurer@chromium.org 2013-07-25 08:00:32 +00:00
parent fbc7770702
commit 3b8c7ffa61
1 changed files with 6 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
src/platform-posix.cc
View File

@ -502,12 +502,11 @@ Thread::~Thread() {
static void SetThreadName(const char* name) {
int result = 0;
#if defined(__DragonFly__) || defined(__FreeBSD__) || defined(__OpenBSD__)
result = pthread_set_name_np(pthread_self(), name);
pthread_set_name_np(pthread_self(), name);
#elif defined(__NetBSD__)
STATIC_ASSERT(Thread::kMaxThreadNameLength <= PTHREAD_MAX_NAMELEN_NP);
result = pthread_setname_np(pthread_self(), "%s", name);
pthread_setname_np(pthread_self(), "%s", name);
#elif defined(__APPLE__)
// pthread_setname_np is only available in 10.6 or later, so test
// for it at runtime.
@ -520,14 +519,12 @@ static void SetThreadName(const char* name) {
// Mac OS X does not expose the length limit of the name, so hardcode it.
static const int kMaxNameLength = 63;
STATIC_ASSERT(Thread::kMaxThreadNameLength <= kMaxNameLength);
result = dynamic_pthread_setname_np(name);
dynamic_pthread_setname_np(name);
#elif defined(PR_SET_NAME)
result = prctl(PR_SET_NAME,
prctl(PR_SET_NAME,
reinterpret_cast<unsigned long>(name), // NOLINT
0, 0, 0);
#endif
ASSERT_EQ(0, result);
USE(result);
}