AuroraMiddleware/v8
1
0
Fork 0
Code Issues 2 Pull Requests Releases Wiki Activity

[heap] Skip more tests for TPH

Browse Source 
This CL skips some recently added tests that do not work for TPH at the moment,
including:

* One uses --concurrent_inlining
* One Requires local heaps
* 7 tests that create multiple isplates
* 3 LogMaps* tests that is expected to fail due to map address reuse

This CL also set v8_enable_allocation_folding = true for TPH.

Bug: v8:11641
Change-Id: I5db32f5f9e730dc4e12e4869ec78210bde23ca0d
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2994219
Commit-Queue: Wenyu Zhao <wenyu.zhao@anu.edu.au>
Commit-Queue: Dominik Inführ <dinfuehr@chromium.org>
Auto-Submit: Wenyu Zhao <wenyu.zhao@anu.edu.au>
Reviewed-by: Dominik Inführ <dinfuehr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#75432}
This commit is contained in:
Wenyu Zhao 2021-06-29 16:33:21 +10:00 committed by V8 LUCI CQ
parent b437c447eb
commit 3b9a093282
4 changed files with 14 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
BUILD.gn
View File

@ -414,6 +414,7 @@ if (v8_enable_third_party_heap) {
v8_enable_shared_ro_heap = false
v8_enable_pointer_compression = false
v8_enable_pointer_compression_shared_cage = false
v8_enable_allocation_folding = false
}
if (v8_enable_single_generation) {
v8_allocation_site_tracking = false

6
test/cctest/test-log.cc
View File

@ -908,7 +908,7 @@ void ValidateMapDetailsLogging(v8::Isolate* isolate,
UNINITIALIZED_TEST(LogMapsDetailsStartup) {
// Reusing map addresses might cause these tests to fail.
if (i::FLAG_gc_global || i::FLAG_stress_compaction ||
i::FLAG_stress_incremental_marking) {
i::FLAG_stress_incremental_marking || i::FLAG_enable_third_party_heap) {
return;
}
// Test that all Map details from Maps in the snapshot are logged properly.
@ -930,7 +930,7 @@ UNINITIALIZED_TEST(LogMapsDetailsStartup) {
UNINITIALIZED_TEST(LogMapsDetailsCode) {
// Reusing map addresses might cause these tests to fail.
if (i::FLAG_gc_global || i::FLAG_stress_compaction ||
i::FLAG_stress_incremental_marking) {
i::FLAG_stress_incremental_marking || i::FLAG_enable_third_party_heap) {
return;
}
SETUP_FLAGS();
@ -1027,7 +1027,7 @@ UNINITIALIZED_TEST(LogMapsDetailsCode) {
UNINITIALIZED_TEST(LogMapsDetailsContexts) {
// Reusing map addresses might cause these tests to fail.
if (i::FLAG_gc_global || i::FLAG_stress_compaction ||
i::FLAG_stress_incremental_marking) {
i::FLAG_stress_incremental_marking || i::FLAG_enable_third_party_heap) {
return;
}
// Test that all Map details from Maps in the snapshot are logged properly.

6
test/inspector/inspector.status
View File

@ -213,6 +213,12 @@
################################################################################
['third_party_heap', {
# Requires a second isolate
'debugger/stepping-generator-parameters': [SKIP],
'debugger/wasm-externref-global': [SKIP],
'debugger/stepping-async-generator': [SKIP],
'regress/regress-crbug-1222065': [SKIP],
'debugger/stepping-generator': [SKIP],
'runtime/exception-thrown-metadata': [SKIP],
'debugger/wasm-side-effect-free-debug-evaluate': [SKIP],
'regress/regress-crbug-1081162': [SKIP],
'regress/regress-crbug-1207867': [SKIP],

4
test/mjsunit/mjsunit.status
View File

@ -1531,7 +1531,10 @@
################################################################################
['third_party_heap', {
# Requires local heaps
'const-field-tracking': [SKIP],
# Requires --concurrent_inlining / --finalize_streaming_on_background:
'regress/regress-1220974': [SKIP],
'regress-1146106': [SKIP],
'compiler/bound-functions-serialize': [SKIP],
'regress/regress-1003730': [SKIP],
@ -1552,6 +1555,7 @@
'regress/regress-356053': [SKIP],
'regress/regress-embedded-cons-string': [SKIP],
# Requires a second isolate
'regress/regress-1212404': [SKIP],
'resizablearraybuffer-growablesharedarraybuffer': [SKIP],
'regress/regress-1205290': [SKIP],
'compiler/regress-725743': [SKIP],