AuroraMiddleware/v8
1
0
Fork 0
Code Issues 2 Pull Requests Releases Wiki Activity

[api] Remove deprecated wasm type and methods

Browse Source 
They have been deprecated in v7.9, hence they can be removed in v8.0.

R=ulan@chromium.org
CC=​mstarzinger@chromium.org

Bug: v8:10021
Change-Id: Ic21c5ee5703b548ddcca2ffeba6c583715d3fbd3
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1864947
Commit-Queue: Clemens Backes <clemensb@chromium.org>
Reviewed-by: Ulan Degenbaev <ulan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#65237}
This commit is contained in:
Clemens Backes 2019-10-18 15:14:44 +02:00 committed by Commit Bot
parent d03802c6d2
commit 3bbadd008b
2 changed files with 0 additions and 34 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

23
include/v8.h
View File

@ -4672,29 +4672,6 @@ class V8_EXPORT WasmModuleObject : public Object {
public:
WasmModuleObject() = delete;
/**
* An opaque, native heap object for transferring wasm modules. It
* supports move semantics, and does not support copy semantics.
*/
using TransferrableModule V8_DEPRECATED("Use CompiledWasmModule directly") =
CompiledWasmModule;
/**
* Get an in-memory, non-persistable, and context-independent (meaning,
* suitable for transfer to another Isolate and Context) representation
* of this wasm compiled module.
*/
V8_DEPRECATED("Use GetCompiledModule")
TransferrableModule GetTransferrableModule();
/**
* Efficiently re-create a WasmModuleObject, without recompiling, from
* a TransferrableModule.
*/
V8_DEPRECATED("Use FromCompiledModule")
static MaybeLocal<WasmModuleObject> FromTransferrableModule(
Isolate* isolate, const TransferrableModule&);
/**
* Efficiently re-create a WasmModuleObject, without recompiling, from
* a CompiledWasmModule.

11
src/api/api.cc
View File

@ -7191,23 +7191,12 @@ MemorySpan<const uint8_t> CompiledWasmModule::GetWireBytesRef() {
return {bytes_vec.begin(), bytes_vec.size()};
}
WasmModuleObject::TransferrableModule
WasmModuleObject::GetTransferrableModule() {
return GetCompiledModule();
}
CompiledWasmModule WasmModuleObject::GetCompiledModule() {
i::Handle<i::WasmModuleObject> obj =
i::Handle<i::WasmModuleObject>::cast(Utils::OpenHandle(this));
return Utils::Convert(obj->shared_native_module());
}
MaybeLocal<WasmModuleObject> WasmModuleObject::FromTransferrableModule(
Isolate* isolate,
const WasmModuleObject::TransferrableModule& transferrable_module) {
return FromCompiledModule(isolate, transferrable_module);
}
MaybeLocal<WasmModuleObject> WasmModuleObject::FromCompiledModule(
Isolate* isolate, const CompiledWasmModule& compiled_module) {
i::Isolate* i_isolate = reinterpret_cast<i::Isolate*>(isolate);