From 3be28afbb9c57e8ae9586caaacd5af1e03542db3 Mon Sep 17 00:00:00 2001 From: Clemens Backes Date: Wed, 17 Nov 2021 12:02:27 +0100 Subject: [PATCH] [wasm] Include source URL in tracing For streaming compilation, include the source URL in tracing, to help identifying problems with caching. R=ahaas@chromium.org Change-Id: Iefda71890024a4fc9ec933c34c5870ba697bbff9 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3289148 Reviewed-by: Andreas Haas Commit-Queue: Clemens Backes Cr-Commit-Position: refs/heads/main@{#77950} --- src/wasm/wasm-js.cc | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/wasm/wasm-js.cc b/src/wasm/wasm-js.cc index ff7840371b..aabf524fbd 100644 --- a/src/wasm/wasm-js.cc +++ b/src/wasm/wasm-js.cc @@ -137,7 +137,8 @@ void WasmStreaming::SetClient(std::shared_ptr client) { } void WasmStreaming::SetUrl(const char* url, size_t length) { - TRACE_EVENT0("v8.wasm", "wasm.SetUrl"); + DCHECK_EQ('\0', url[length]); // {url} is null-terminated. + TRACE_EVENT1("v8.wasm", "wasm.SetUrl", "url", url); impl_->SetUrl(base::VectorOf(url, length)); }