[build] Set MSVS .obj folders in gyp for v8_base
Building on Windows with gyp fails depending on the result from sharding the src/v8.gyp:v8_base target. If two source files with the same name are in the same shard, their output object file path would conflict with one another. One example of this conflict is v8_base's runtime/runtime.cc and the V8 inspector's protocol/Runtime.cpp that is generated at build time, for which the files runtime.obj and Runtime.obj would be created, but MSVS overwrites one of them with the other. Dividing the .obj output path by the original source's extension prevents this overwrite. Refs: https://github.com/nodejs/node/pull/13959 Bug: Change-Id: I158e6178f2511297899ee50ea159f574916f903f Reviewed-on: https://chromium-review.googlesource.com/556599 Reviewed-by: Michael Achenbach <machenbach@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#46354}
This commit is contained in:
parent
89154bf681
commit
3bef2af6ef
1
AUTHORS
1
AUTHORS
@ -70,6 +70,7 @@ Hirofumi Mako <mkhrfm@gmail.com>
|
||||
Honggyu Kim <honggyu.kp@gmail.com>
|
||||
Ioseb Dzmanashvili <ioseb.dzmanashvili@gmail.com>
|
||||
Isiah Meadows <impinball@gmail.com>
|
||||
Jaime Bernardo <jaime@janeasystems.com>
|
||||
Jan de Mooij <jandemooij@gmail.com>
|
||||
Jay Freeman <saurik@saurik.com>
|
||||
James Pike <g00gle@chilon.net>
|
||||
|
@ -1803,6 +1803,13 @@
|
||||
# limit. This breaks it into multiple pieces to avoid the limit.
|
||||
# See http://crbug.com/485155.
|
||||
'msvs_shard': 4,
|
||||
# This will prevent V8's .cc files conflicting with the inspector's
|
||||
# .cpp files in the same shard.
|
||||
'msvs_settings': {
|
||||
'VCCLCompilerTool': {
|
||||
'ObjectFile':'$(IntDir)%(Extension)\\',
|
||||
},
|
||||
},
|
||||
}],
|
||||
['component=="shared_library"', {
|
||||
'defines': [
|
||||
|
Loading…
Reference in New Issue
Block a user