AuroraMiddleware/v8
1
0
Fork 0
Code Issues 2 Pull Requests Releases Wiki Activity

arm: Fix Smi check in SubStringStub::Generate

Browse Source 
R=ulan@chromium.org

Review URL: https://codereview.chromium.org/256743007

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@21050 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
This commit is contained in:
jkummerow@chromium.org 2014-04-29 13:42:00 +00:00
parent 99d9712bb0
commit 3bf07da530
1 changed files with 2 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/arm/code-stubs-arm.cc
View File

@ -3391,10 +3391,8 @@ void SubStringStub::Generate(MacroAssembler* masm) {
// Make sure first argument is a string.
__ ldr(r0, MemOperand(sp, kStringOffset));
// Do a JumpIfSmi, but fold its jump into the subsequent string test.
__ SmiTst(r0);
Condition is_string = masm->IsObjectStringType(r0, r1, ne);
ASSERT(is_string == eq);
__ JumpIfSmi(r0, &runtime);
Condition is_string = masm->IsObjectStringType(r0, r1);
__ b(NegateCondition(is_string), &runtime);
Label single_char;