AuroraMiddleware/v8
1
0
Fork 0
Code Issues 2 Pull Requests Releases Wiki Activity

[turbofan] Funnel class constructors through TurboFan.

Browse Source 
This makes optimization of all class constructors (i.e. both base and
derived) go through TurboFan. Note some class constructors containing
Harmony language features (e.g. super constructor calls or accesses to
the new.target value) were already going through TurboFan before.

R=bmeurer@chromium.org
BUG=v8:5458

Review-Url: https://codereview.chromium.org/2397723002
Cr-Commit-Position: refs/heads/master@{#40342}
This commit is contained in:
mstarzinger 2016-10-17 01:58:16 -07:00 committed by Commit bot
parent 87ae05c7c4
commit 3c6bbe07e8
4 changed files with 19 additions and 14 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/ast/ast-numbering.cc
View File

@ -600,6 +600,10 @@ bool AstNumberingVisitor::Renumber(FunctionLiteral* node) {
} }
} }
if (IsClassConstructor(node->kind())) {
DisableCrankshaft(kClassConstructorFunction);
}
VisitDeclarations(scope->declarations()); VisitDeclarations(scope->declarations());
VisitStatements(node->body()); VisitStatements(node->body());

1
src/bailout-reason.h
View File

@ -35,6 +35,7 @@ namespace internal {
V(kBailoutWasNotPrepared, "Bailout was not prepared") \ V(kBailoutWasNotPrepared, "Bailout was not prepared") \
V(kBothRegistersWereSmisInSelectNonSmi, \ V(kBothRegistersWereSmisInSelectNonSmi, \
"Both registers were smis in SelectNonSmi") \ "Both registers were smis in SelectNonSmi") \
V(kClassConstructorFunction, "Class constructor function") \
V(kClassLiteral, "Class literal") \ V(kClassLiteral, "Class literal") \
V(kCodeGenerationFailed, "Code generation failed") \ V(kCodeGenerationFailed, "Code generation failed") \
V(kCodeObjectNotProperlyPatched, "Code object not properly patched") \ V(kCodeObjectNotProperlyPatched, "Code object not properly patched") \

8
test/cctest/interpreter/bytecode_expectations/Generators.golden
View File

@ -22,7 +22,7 @@ bytecodes: [
B(LdaZero), B(LdaZero),
B(TestEqualStrict), R(1), U8(0), B(TestEqualStrict), R(1), U8(0),
B(JumpIfTrue), U8(61), B(JumpIfTrue), U8(61),
B(LdaSmi), U8(76), B(LdaSmi), U8(77),
B(Star), R(2), B(Star), R(2),
B(CallRuntime), U16(Runtime::kAbort), R(2), U8(1), B(CallRuntime), U16(Runtime::kAbort), R(2), U8(1),
B(LdaSmi), U8(-2), B(LdaSmi), U8(-2),
@ -130,7 +130,7 @@ bytecodes: [
B(LdaSmi), U8(1), B(LdaSmi), U8(1),
B(TestEqualStrict), R(1), U8(0), B(TestEqualStrict), R(1), U8(0),
B(JumpIfTrueConstant), U8(0), B(JumpIfTrueConstant), U8(0),
B(LdaSmi), U8(76), B(LdaSmi), U8(77),
B(Star), R(2), B(Star), R(2),
B(CallRuntime), U16(Runtime::kAbort), R(2), U8(1), B(CallRuntime), U16(Runtime::kAbort), R(2), U8(1),
B(LdaSmi), U8(-2), B(LdaSmi), U8(-2),
@ -278,7 +278,7 @@ bytecodes: [
B(LdaSmi), U8(1), B(LdaSmi), U8(1),
B(TestEqualStrict), R(4), U8(0), B(TestEqualStrict), R(4), U8(0),
B(JumpIfTrueConstant), U8(3), B(JumpIfTrueConstant), U8(3),
B(LdaSmi), U8(76), B(LdaSmi), U8(77),
B(Star), R(5), B(Star), R(5),
B(CallRuntime), U16(Runtime::kAbort), R(5), U8(1), B(CallRuntime), U16(Runtime::kAbort), R(5), U8(1),
B(LdaSmi), U8(-2), B(LdaSmi), U8(-2),
@ -344,7 +344,7 @@ bytecodes: [
B(LdaSmi), U8(1), B(LdaSmi), U8(1),
B(TestEqualStrict), R(4), U8(0), B(TestEqualStrict), R(4), U8(0),
B(JumpIfTrueConstant), U8(9), B(JumpIfTrueConstant), U8(9),
B(LdaSmi), U8(76), B(LdaSmi), U8(77),
B(Star), R(12), B(Star), R(12),
B(CallRuntime), U16(Runtime::kAbort), R(12), U8(1), B(CallRuntime), U16(Runtime::kAbort), R(12), U8(1),
/* 27 S> */ B(LdrContextSlot), R(1), U8(7), U8(0), R(14), /* 27 S> */ B(LdrContextSlot), R(1), U8(7), U8(0), R(14),

20
test/cctest/interpreter/bytecode_expectations/Modules.golden
View File

@ -22,7 +22,7 @@ bytecodes: [
B(LdaZero), B(LdaZero),
B(TestEqualStrict), R(1), U8(0), B(TestEqualStrict), R(1), U8(0),
B(JumpIfTrue), U8(71), B(JumpIfTrue), U8(71),
B(LdaSmi), U8(76), B(LdaSmi), U8(77),
B(Star), R(2), B(Star), R(2),
B(CallRuntime), U16(Runtime::kAbort), R(2), U8(1), B(CallRuntime), U16(Runtime::kAbort), R(2), U8(1),
B(LdaSmi), U8(-2), B(LdaSmi), U8(-2),
@ -91,7 +91,7 @@ bytecodes: [
B(LdaZero), B(LdaZero),
B(TestEqualStrict), R(1), U8(0), B(TestEqualStrict), R(1), U8(0),
B(JumpIfTrue), U8(71), B(JumpIfTrue), U8(71),
B(LdaSmi), U8(76), B(LdaSmi), U8(77),
B(Star), R(2), B(Star), R(2),
B(CallRuntime), U16(Runtime::kAbort), R(2), U8(1), B(CallRuntime), U16(Runtime::kAbort), R(2), U8(1),
B(LdaSmi), U8(-2), B(LdaSmi), U8(-2),
@ -162,7 +162,7 @@ bytecodes: [
B(LdaZero), B(LdaZero),
B(TestEqualStrict), R(2), U8(0), B(TestEqualStrict), R(2), U8(0),
B(JumpIfTrue), U8(71), B(JumpIfTrue), U8(71),
B(LdaSmi), U8(76), B(LdaSmi), U8(77),
B(Star), R(3), B(Star), R(3),
B(CallRuntime), U16(Runtime::kAbort), R(3), U8(1), B(CallRuntime), U16(Runtime::kAbort), R(3), U8(1),
B(LdaSmi), U8(-2), B(LdaSmi), U8(-2),
@ -272,7 +272,7 @@ bytecodes: [
B(LdaZero), B(LdaZero),
B(TestEqualStrict), R(2), U8(0), B(TestEqualStrict), R(2), U8(0),
B(JumpIfTrue), U8(71), B(JumpIfTrue), U8(71),
B(LdaSmi), U8(76), B(LdaSmi), U8(77),
B(Star), R(3), B(Star), R(3),
B(CallRuntime), U16(Runtime::kAbort), R(3), U8(1), B(CallRuntime), U16(Runtime::kAbort), R(3), U8(1),
B(LdaSmi), U8(-2), B(LdaSmi), U8(-2),
@ -374,7 +374,7 @@ bytecodes: [
B(LdaZero), B(LdaZero),
B(TestEqualStrict), R(2), U8(0), B(TestEqualStrict), R(2), U8(0),
B(JumpIfTrue), U8(83), B(JumpIfTrue), U8(83),
B(LdaSmi), U8(76), B(LdaSmi), U8(77),
B(Star), R(3), B(Star), R(3),
B(CallRuntime), U16(Runtime::kAbort), R(3), U8(1), B(CallRuntime), U16(Runtime::kAbort), R(3), U8(1),
B(LdaSmi), U8(-2), B(LdaSmi), U8(-2),
@ -489,7 +489,7 @@ bytecodes: [
B(LdaZero), B(LdaZero),
B(TestEqualStrict), R(2), U8(0), B(TestEqualStrict), R(2), U8(0),
B(JumpIfTrue), U8(83), B(JumpIfTrue), U8(83),
B(LdaSmi), U8(76), B(LdaSmi), U8(77),
B(Star), R(3), B(Star), R(3),
B(CallRuntime), U16(Runtime::kAbort), R(3), U8(1), B(CallRuntime), U16(Runtime::kAbort), R(3), U8(1),
B(LdaSmi), U8(-2), B(LdaSmi), U8(-2),
@ -596,7 +596,7 @@ bytecodes: [
B(LdaZero), B(LdaZero),
B(TestEqualStrict), R(1), U8(0), B(TestEqualStrict), R(1), U8(0),
B(JumpIfTrue), U8(83), B(JumpIfTrue), U8(83),
B(LdaSmi), U8(76), B(LdaSmi), U8(77),
B(Star), R(2), B(Star), R(2),
B(CallRuntime), U16(Runtime::kAbort), R(2), U8(1), B(CallRuntime), U16(Runtime::kAbort), R(2), U8(1),
B(LdaSmi), U8(-2), B(LdaSmi), U8(-2),
@ -677,7 +677,7 @@ bytecodes: [
B(LdaZero), B(LdaZero),
B(TestEqualStrict), R(1), U8(0), B(TestEqualStrict), R(1), U8(0),
B(JumpIfTrue), U8(83), B(JumpIfTrue), U8(83),
B(LdaSmi), U8(76), B(LdaSmi), U8(77),
B(Star), R(2), B(Star), R(2),
B(CallRuntime), U16(Runtime::kAbort), R(2), U8(1), B(CallRuntime), U16(Runtime::kAbort), R(2), U8(1),
B(LdaSmi), U8(-2), B(LdaSmi), U8(-2),
@ -771,7 +771,7 @@ bytecodes: [
B(LdaZero), B(LdaZero),
B(TestEqualStrict), R(1), U8(0), B(TestEqualStrict), R(1), U8(0),
B(JumpIfTrue), U8(71), B(JumpIfTrue), U8(71),
B(LdaSmi), U8(76), B(LdaSmi), U8(77),
B(Star), R(2), B(Star), R(2),
B(CallRuntime), U16(Runtime::kAbort), R(2), U8(1), B(CallRuntime), U16(Runtime::kAbort), R(2), U8(1),
B(LdaSmi), U8(-2), B(LdaSmi), U8(-2),
@ -840,7 +840,7 @@ bytecodes: [
B(LdaZero), B(LdaZero),
B(TestEqualStrict), R(1), U8(0), B(TestEqualStrict), R(1), U8(0),
B(JumpIfTrue), U8(71), B(JumpIfTrue), U8(71),
B(LdaSmi), U8(76), B(LdaSmi), U8(77),
B(Star), R(2), B(Star), R(2),
B(CallRuntime), U16(Runtime::kAbort), R(2), U8(1), B(CallRuntime), U16(Runtime::kAbort), R(2), U8(1),
B(LdaSmi), U8(-2), B(LdaSmi), U8(-2),