AuroraMiddleware/v8
1
0
Fork 0
Code Issues 2 Pull Requests Releases Wiki Activity

Add a prepare to parse step to CompilerDispatcherJob

Browse Source 
R=marja@chromium.org
BUG=v8:5215

Review-Url: https://codereview.chromium.org/2191443003
Cr-Commit-Position: refs/heads/master@{#38114}
This commit is contained in:
jochen 2016-07-28 00:46:15 -07:00 committed by Commit bot
parent 784a636f3e
commit 3ca98851df
3 changed files with 41 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
src/compiler-dispatcher/compiler-dispatcher-job.cc
View File

@ -7,6 +7,9 @@
#include "src/global-handles.h"
#include "src/isolate.h"
#include "src/objects-inl.h"
#include "src/parsing/parser.h"
#include "src/unicode-cache.h"
#include "src/zone.h"
namespace v8 {
namespace internal {
@ -18,8 +21,22 @@ CompilerDispatcherJob::CompilerDispatcherJob(Isolate* isolate,
isolate_->global_handles()->Create(*function))) {}
CompilerDispatcherJob::~CompilerDispatcherJob() {
DCHECK(ThreadId::Current().Equals(isolate_->thread_id()));
i::GlobalHandles::Destroy(Handle<Object>::cast(function_).location());
}
void CompilerDispatcherJob::PrepareToParseOnMainThread() {
DCHECK(ThreadId::Current().Equals(isolate_->thread_id()));
DCHECK(status_ == CompileJobStatus::kInitial);
unicode_cache_.reset(new UnicodeCache());
zone_.reset(new Zone(isolate_->allocator()));
parse_info_.reset(new ParseInfo(zone_.get()));
parse_info_->set_isolate(isolate_);
// TODO(jochen): We need to hook up a fake source stream here.
parse_info_->set_hash_seed(isolate_->heap()->HashSeed());
parse_info_->set_unicode_cache(unicode_cache_.get());
status_ = CompileJobStatus::kReadyToParse;
}
} // namespace internal
} // namespace v8

15
src/compiler-dispatcher/compiler-dispatcher-job.h
View File

@ -5,8 +5,9 @@
#ifndef V8_COMPILER_DISPATCHER_COMPILER_DISPATCHER_JOB_H_
#define V8_COMPILER_DISPATCHER_COMPILER_DISPATCHER_JOB_H_
#include "src/base/macros.h"
#include <memory>
#include "src/base/macros.h"
#include "src/handles.h"
namespace v8 {
@ -15,9 +16,13 @@ namespace internal {
class CompilationInfo;
class Isolate;
class JSFunction;
class ParseInfo;
class UnicodeCache;
class Zone;
enum class CompileJobStatus {
kInitial,
kReadyToParse,
};
class CompilerDispatcherJob {
@ -27,11 +32,19 @@ class CompilerDispatcherJob {
CompileJobStatus status() const { return status_; }
// Transition from kInitial to kReadyToParse.
void PrepareToParseOnMainThread();
private:
CompileJobStatus status_ = CompileJobStatus::kInitial;
Isolate* isolate_;
Handle<JSFunction> function_; // Global handle.
// Members required for parsing.
std::unique_ptr<UnicodeCache> unicode_cache_;
std::unique_ptr<Zone> zone_;
std::unique_ptr<ParseInfo> parse_info_;
DISALLOW_COPY_AND_ASSIGN(CompilerDispatcherJob);
};

10
test/unittests/compiler-dispatcher/compiler-dispatcher-job-unittest.cc
View File

@ -20,5 +20,15 @@ TEST_F(CompilerDispatcherJobTest, Construct) {
new CompilerDispatcherJob(i_isolate, i_isolate->object_function()));
}
TEST_F(CompilerDispatcherJobTest, PrepareToParse) {
Isolate* i_isolate = reinterpret_cast<Isolate*>(isolate());
std::unique_ptr<CompilerDispatcherJob> job(
new CompilerDispatcherJob(i_isolate, i_isolate->object_function()));
ASSERT_TRUE(job->status() == CompileJobStatus::kInitial);
job->PrepareToParseOnMainThread();
ASSERT_TRUE(job->status() == CompileJobStatus::kReadyToParse);
}
} // namespace internal
} // namespace v8