AuroraMiddleware/v8
1
0
Fork 0
Code Issues 2 Pull Requests Releases Wiki Activity

[heap] Fix fast promotion mode computation

Browse Source 
Bailout didn't happen if we decided to shrink newspace at the end of a
Mark-Compact GC.

BUG=chromium:693413

Change-Id: Ia4acf565c836b188655773e74083f9151e4ab30b
Reviewed-on: https://chromium-review.googlesource.com/445176
Reviewed-by: Ulan Degenbaev <ulan@chromium.org>
Commit-Queue: Michael Lippautz <mlippautz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#43320}
This commit is contained in:
Michael Lippautz 2017-02-20 13:48:26 +01:00 committed by Commit Bot
parent 2c7f32e21c
commit 3cf5edae90
1 changed files with 7 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
src/heap/heap.cc
View File

@ -1799,16 +1799,15 @@ void Heap::Scavenge() {
} }
void Heap::ComputeFastPromotionMode(double survival_rate) { void Heap::ComputeFastPromotionMode(double survival_rate) {
if (new_space_->IsAtMaximumCapacity() && !FLAG_optimize_for_size) {
fast_promotion_mode_ = fast_promotion_mode_ =
FLAG_fast_promotion_new_space && !FLAG_optimize_for_size && FLAG_fast_promotion_new_space &&
new_space_->IsAtMaximumCapacity() &&
survival_rate >= kMinPromotedPercentForFastPromotionMode; survival_rate >= kMinPromotedPercentForFastPromotionMode;
if (FLAG_trace_gc_verbose) { if (FLAG_trace_gc_verbose) {
PrintIsolate(isolate(), "Fast promotion mode: %s survival rate: %f%%\n", PrintIsolate(isolate(), "Fast promotion mode: %s survival rate: %f%%\n",
fast_promotion_mode_ ? "true" : "false", survival_rate); fast_promotion_mode_ ? "true" : "false", survival_rate);
} }
} }
}
String* Heap::UpdateNewSpaceReferenceInExternalStringTableEntry(Heap* heap, String* Heap::UpdateNewSpaceReferenceInExternalStringTableEntry(Heap* heap,
Object** p) { Object** p) {