AuroraMiddleware/v8
1
0
Fork 0
Code Issues 2 Pull Requests Releases Wiki Activity

Reenable readability/check cpplint check

Browse Source 
And fix the last violations which were introduced since the cleanup CLs
landed.

R=mstarzinger@chromium.org, jgruber@chromium.org

Bug: v8:6837, v8:6921
Change-Id: I317cce06f1e5c2bcdd57283c9c1b75cbe6415cbb
Reviewed-on: https://chromium-review.googlesource.com/727885
Reviewed-by: Michael Starzinger <mstarzinger@chromium.org>
Reviewed-by: Jakob Gruber <jgruber@chromium.org>
Commit-Queue: Clemens Hammacher <clemensh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#48756}
This commit is contained in:
Clemens Hammacher 2017-10-19 14:57:00 +02:00 committed by Commit Bot
parent 26ae938058
commit 3d4a982685
3 changed files with 5 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/objects/bigint.cc
View File

@ -434,7 +434,7 @@ ComparisonResult BigInt::CompareToDouble(Handle<BigInt> x, double y) {
compare_mantissa = mantissa >> remaining_mantissa_bits;
mantissa = mantissa << (64 - remaining_mantissa_bits);
} else {
DCHECK(msd_topbit >= kMantissaTopBit);
DCHECK_GE(msd_topbit, kMantissaTopBit);
compare_mantissa = mantissa << (msd_topbit - kMantissaTopBit);
mantissa = 0;
}
@ -463,7 +463,7 @@ ComparisonResult BigInt::CompareToDouble(Handle<BigInt> x, double y) {
// Integer parts are equal; check whether {y} has a fractional part.
if (mantissa != 0) {
DCHECK(remaining_mantissa_bits > 0);
DCHECK_GT(remaining_mantissa_bits, 0);
return AbsoluteLess(x_sign);
}
return ComparisonResult::kEqual;

6
src/snapshot/default-deserializer-allocator.cc
View File

@ -43,7 +43,7 @@ Address DefaultDeserializerAllocator::AllocateRaw(AllocationSpace space,
DCHECK_EQ(Map::kSize, size);
return allocated_maps_[next_map_index_++];
} else {
DCHECK(space < kNumberOfPreallocatedSpaces);
DCHECK_LT(space, kNumberOfPreallocatedSpaces);
Address address = high_water_[space];
DCHECK_NOT_NULL(address);
high_water_[space] += size;
@ -84,7 +84,7 @@ Address DefaultDeserializerAllocator::Allocate(AllocationSpace space,
}
void DefaultDeserializerAllocator::MoveToNextChunk(AllocationSpace space) {
DCHECK(space < kNumberOfPreallocatedSpaces);
DCHECK_LT(space, kNumberOfPreallocatedSpaces);
uint32_t chunk_index = current_chunk_[space];
const Heap::Reservation& reservation = reservations_[space];
// Make sure the current chunk is indeed exhausted.
@ -136,7 +136,7 @@ void DefaultDeserializerAllocator::DecodeReservation(
bool DefaultDeserializerAllocator::ReserveSpace() {
#ifdef DEBUG
for (int i = NEW_SPACE; i < kNumberOfSpaces; ++i) {
DCHECK(reservations_[i].size() > 0);
DCHECK_GT(reservations_[i].size(), 0);
}
#endif // DEBUG
DCHECK(allocated_maps_.empty());

2
tools/presubmit.py
View File

@ -54,12 +54,10 @@ from testrunner.local import utils
# build/header_guard: Our guards have the form "V8_FOO_H_", not "SRC_FOO_H_".
# build/include_what_you_use: Started giving false positives for variables
# named "string" and "map" assuming that you needed to include STL headers.
# TODO(bmeurer): Fix and re-enable readability/check
LINT_RULES = """
-build/header_guard
-build/include_what_you_use
-readability/check
-readability/fn_size
-runtime/references
""".split()