AuroraMiddleware/v8
1
0
Fork 0
Code Issues 2 Pull Requests Releases Wiki Activity

CPUProfiler: Simplify CodeEntry constructor calls.

Browse Source 
In almost all the places where we create CodeEntry we use default values.
Lets move them into arguments default values.

BUG=none
TEST=no logic changes.
R=yangguo@chromium.org, yurys@chromium.org

Committed: https://code.google.com/p/v8/source/detail?r=15333

Review URL: https://codereview.chromium.org/17836002

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@15340 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
This commit is contained in:
loislo@chromium.org 2013-06-26 16:04:25 +00:00
parent f3f14fc7ed
commit 3da5ba9ac3
4 changed files with 39 additions and 70 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/profile-generator-inl.h
View File

@ -46,9 +46,9 @@ const char* StringsStorage::GetFunctionName(const char* name) {
CodeEntry::CodeEntry(Logger::LogEventsAndTags tag, CodeEntry::CodeEntry(Logger::LogEventsAndTags tag,
const char* name_prefix, const char* name_prefix,
const char* name, const char* name,
int security_token_id,
const char* resource_name, const char* resource_name,
int line_number, int line_number)
int security_token_id)
: tag_(tag), : tag_(tag),
name_prefix_(name_prefix), name_prefix_(name_prefix),
name_(name), name_(name),

22
src/profile-generator.cc
View File

@ -183,7 +183,9 @@ size_t StringsStorage::GetUsedMemorySize() const {
return size; return size;
} }
const char* const CodeEntry::kEmptyNamePrefix = ""; const char* const CodeEntry::kEmptyNamePrefix = "";
const char* const CodeEntry::kEmptyResourceName = "";
CodeEntry::~CodeEntry() { CodeEntry::~CodeEntry() {
@ -296,12 +298,7 @@ class DeleteNodesCallback {
ProfileTree::ProfileTree() ProfileTree::ProfileTree()
: root_entry_(Logger::FUNCTION_TAG, : root_entry_(Logger::FUNCTION_TAG, "", "(root)"),
"",
"(root)",
"",
0,
TokenEnumerator::kNoSecurityToken),
next_node_id_(1), next_node_id_(1),
root_(new ProfileNode(this, &root_entry_)) { root_(new ProfileNode(this, &root_entry_)) {
} }
@ -797,9 +794,9 @@ CodeEntry* CpuProfilesCollection::NewCodeEntry(Logger::LogEventsAndTags tag,
CodeEntry* entry = new CodeEntry(tag, CodeEntry* entry = new CodeEntry(tag,
CodeEntry::kEmptyNamePrefix, CodeEntry::kEmptyNamePrefix,
GetFunctionName(name), GetFunctionName(name),
TokenEnumerator::kNoSecurityToken,
GetName(resource_name), GetName(resource_name),
line_number, line_number);
TokenEnumerator::kNoSecurityToken);
code_entries_.Add(entry); code_entries_.Add(entry);
return entry; return entry;
} }
@ -809,10 +806,7 @@ CodeEntry* CpuProfilesCollection::NewCodeEntry(Logger::LogEventsAndTags tag,
const char* name) { const char* name) {
CodeEntry* entry = new CodeEntry(tag, CodeEntry* entry = new CodeEntry(tag,
CodeEntry::kEmptyNamePrefix, CodeEntry::kEmptyNamePrefix,
GetFunctionName(name), GetFunctionName(name));
"",
v8::CpuProfileNode::kNoLineNumberInfo,
TokenEnumerator::kNoSecurityToken);
code_entries_.Add(entry); code_entries_.Add(entry);
return entry; return entry;
} }
@ -824,8 +818,6 @@ CodeEntry* CpuProfilesCollection::NewCodeEntry(Logger::LogEventsAndTags tag,
CodeEntry* entry = new CodeEntry(tag, CodeEntry* entry = new CodeEntry(tag,
name_prefix, name_prefix,
GetName(name), GetName(name),
"",
v8::CpuProfileNode::kNoLineNumberInfo,
TokenEnumerator::kInheritsSecurityToken); TokenEnumerator::kInheritsSecurityToken);
code_entries_.Add(entry); code_entries_.Add(entry);
return entry; return entry;
@ -837,8 +829,6 @@ CodeEntry* CpuProfilesCollection::NewCodeEntry(Logger::LogEventsAndTags tag,
CodeEntry* entry = new CodeEntry(tag, CodeEntry* entry = new CodeEntry(tag,
"args_count: ", "args_count: ",
GetName(args_count), GetName(args_count),
"",
v8::CpuProfileNode::kNoLineNumberInfo,
TokenEnumerator::kInheritsSecurityToken); TokenEnumerator::kInheritsSecurityToken);
code_entries_.Add(entry); code_entries_.Add(entry);
return entry; return entry;

7
src/profile-generator.h
View File

@ -99,9 +99,9 @@ class CodeEntry {
INLINE(CodeEntry(Logger::LogEventsAndTags tag, INLINE(CodeEntry(Logger::LogEventsAndTags tag,
const char* name_prefix, const char* name_prefix,
const char* name, const char* name,
const char* resource_name, int security_token_id = TokenEnumerator::kNoSecurityToken,
int line_number, const char* resource_name = CodeEntry::kEmptyResourceName,
int security_token_id)); int line_number = v8::CpuProfileNode::kNoLineNumberInfo));
~CodeEntry(); ~CodeEntry();
INLINE(bool is_js_function() const) { return is_js_function_tag(tag_); } INLINE(bool is_js_function() const) { return is_js_function_tag(tag_); }
@ -125,6 +125,7 @@ class CodeEntry {
bool IsSameAs(CodeEntry* entry) const; bool IsSameAs(CodeEntry* entry) const;
static const char* const kEmptyNamePrefix; static const char* const kEmptyNamePrefix;
static const char* const kEmptyResourceName;
private: private:
Logger::LogEventsAndTags tag_; Logger::LogEventsAndTags tag_;

76
test/cctest/test-profile-generator.cc
View File

@ -87,20 +87,17 @@ TEST(TokenEnumerator) {
TEST(ProfileNodeFindOrAddChild) { TEST(ProfileNodeFindOrAddChild) {
ProfileTree tree; ProfileTree tree;
ProfileNode node(&tree, NULL); ProfileNode node(&tree, NULL);
CodeEntry entry1(i::Logger::FUNCTION_TAG, "", "aaa", "", 0, CodeEntry entry1(i::Logger::FUNCTION_TAG, "", "aaa");
TokenEnumerator::kNoSecurityToken);
ProfileNode* childNode1 = node.FindOrAddChild(&entry1); ProfileNode* childNode1 = node.FindOrAddChild(&entry1);
CHECK_NE(NULL, childNode1); CHECK_NE(NULL, childNode1);
CHECK_EQ(childNode1, node.FindOrAddChild(&entry1)); CHECK_EQ(childNode1, node.FindOrAddChild(&entry1));
CodeEntry entry2(i::Logger::FUNCTION_TAG, "", "bbb", "", 0, CodeEntry entry2(i::Logger::FUNCTION_TAG, "", "bbb");
TokenEnumerator::kNoSecurityToken);
ProfileNode* childNode2 = node.FindOrAddChild(&entry2); ProfileNode* childNode2 = node.FindOrAddChild(&entry2);
CHECK_NE(NULL, childNode2); CHECK_NE(NULL, childNode2);
CHECK_NE(childNode1, childNode2); CHECK_NE(childNode1, childNode2);
CHECK_EQ(childNode1, node.FindOrAddChild(&entry1)); CHECK_EQ(childNode1, node.FindOrAddChild(&entry1));
CHECK_EQ(childNode2, node.FindOrAddChild(&entry2)); CHECK_EQ(childNode2, node.FindOrAddChild(&entry2));
CodeEntry entry3(i::Logger::FUNCTION_TAG, "", "ccc", "", 0, CodeEntry entry3(i::Logger::FUNCTION_TAG, "", "ccc");
TokenEnumerator::kNoSecurityToken);
ProfileNode* childNode3 = node.FindOrAddChild(&entry3); ProfileNode* childNode3 = node.FindOrAddChild(&entry3);
CHECK_NE(NULL, childNode3); CHECK_NE(NULL, childNode3);
CHECK_NE(childNode1, childNode3); CHECK_NE(childNode1, childNode3);
@ -116,17 +113,15 @@ TEST(ProfileNodeFindOrAddChildForSameFunction) {
const char* aaa = "aaa"; const char* aaa = "aaa";
ProfileTree tree; ProfileTree tree;
ProfileNode node(&tree, NULL); ProfileNode node(&tree, NULL);
CodeEntry entry1(i::Logger::FUNCTION_TAG, empty, aaa, empty, 0, CodeEntry entry1(i::Logger::FUNCTION_TAG, empty, aaa);
TokenEnumerator::kNoSecurityToken);
ProfileNode* childNode1 = node.FindOrAddChild(&entry1); ProfileNode* childNode1 = node.FindOrAddChild(&entry1);
CHECK_NE(NULL, childNode1); CHECK_NE(NULL, childNode1);
CHECK_EQ(childNode1, node.FindOrAddChild(&entry1)); CHECK_EQ(childNode1, node.FindOrAddChild(&entry1));
// The same function again. // The same function again.
CodeEntry entry2(i::Logger::FUNCTION_TAG, empty, aaa, empty, 0, CodeEntry entry2(i::Logger::FUNCTION_TAG, empty, aaa);
TokenEnumerator::kNoSecurityToken);
CHECK_EQ(childNode1, node.FindOrAddChild(&entry2)); CHECK_EQ(childNode1, node.FindOrAddChild(&entry2));
// Now with a different security token. // Now with a different security token.
CodeEntry entry3(i::Logger::FUNCTION_TAG, empty, aaa, empty, 0, CodeEntry entry3(i::Logger::FUNCTION_TAG, empty, aaa,
TokenEnumerator::kNoSecurityToken + 1); TokenEnumerator::kNoSecurityToken + 1);
CHECK_EQ(childNode1, node.FindOrAddChild(&entry3)); CHECK_EQ(childNode1, node.FindOrAddChild(&entry3));
} }
@ -162,12 +157,9 @@ class ProfileTreeTestHelper {
} // namespace } // namespace
TEST(ProfileTreeAddPathFromStart) { TEST(ProfileTreeAddPathFromStart) {
CodeEntry entry1(i::Logger::FUNCTION_TAG, "", "aaa", "", 0, CodeEntry entry1(i::Logger::FUNCTION_TAG, "", "aaa");
TokenEnumerator::kNoSecurityToken); CodeEntry entry2(i::Logger::FUNCTION_TAG, "", "bbb");
CodeEntry entry2(i::Logger::FUNCTION_TAG, "", "bbb", "", 0, CodeEntry entry3(i::Logger::FUNCTION_TAG, "", "ccc");
TokenEnumerator::kNoSecurityToken);
CodeEntry entry3(i::Logger::FUNCTION_TAG, "", "ccc", "", 0,
TokenEnumerator::kNoSecurityToken);
ProfileTree tree; ProfileTree tree;
ProfileTreeTestHelper helper(&tree); ProfileTreeTestHelper helper(&tree);
CHECK_EQ(NULL, helper.Walk(&entry1)); CHECK_EQ(NULL, helper.Walk(&entry1));
@ -232,12 +224,9 @@ TEST(ProfileTreeAddPathFromStart) {
TEST(ProfileTreeAddPathFromEnd) { TEST(ProfileTreeAddPathFromEnd) {
CodeEntry entry1(i::Logger::FUNCTION_TAG, "", "aaa", "", 0, CodeEntry entry1(i::Logger::FUNCTION_TAG, "", "aaa");
TokenEnumerator::kNoSecurityToken); CodeEntry entry2(i::Logger::FUNCTION_TAG, "", "bbb");
CodeEntry entry2(i::Logger::FUNCTION_TAG, "", "bbb", "", 0, CodeEntry entry3(i::Logger::FUNCTION_TAG, "", "ccc");
TokenEnumerator::kNoSecurityToken);
CodeEntry entry3(i::Logger::FUNCTION_TAG, "", "ccc", "", 0,
TokenEnumerator::kNoSecurityToken);
ProfileTree tree; ProfileTree tree;
ProfileTreeTestHelper helper(&tree); ProfileTreeTestHelper helper(&tree);
CHECK_EQ(NULL, helper.Walk(&entry1)); CHECK_EQ(NULL, helper.Walk(&entry1));
@ -315,8 +304,7 @@ TEST(ProfileTreeCalculateTotalTicks) {
CHECK_EQ(1, empty_tree.root()->total_ticks()); CHECK_EQ(1, empty_tree.root()->total_ticks());
CHECK_EQ(1, empty_tree.root()->self_ticks()); CHECK_EQ(1, empty_tree.root()->self_ticks());
CodeEntry entry1(i::Logger::FUNCTION_TAG, "", "aaa", "", 0, CodeEntry entry1(i::Logger::FUNCTION_TAG, "", "aaa");
TokenEnumerator::kNoSecurityToken);
CodeEntry* e1_path[] = {&entry1}; CodeEntry* e1_path[] = {&entry1};
Vector<CodeEntry*> e1_path_vec( Vector<CodeEntry*> e1_path_vec(
e1_path, sizeof(e1_path) / sizeof(e1_path[0])); e1_path, sizeof(e1_path) / sizeof(e1_path[0]));
@ -337,8 +325,7 @@ TEST(ProfileTreeCalculateTotalTicks) {
CHECK_EQ(1, node1->total_ticks()); CHECK_EQ(1, node1->total_ticks());
CHECK_EQ(1, node1->self_ticks()); CHECK_EQ(1, node1->self_ticks());
CodeEntry entry2(i::Logger::FUNCTION_TAG, "", "bbb", "", 0, CodeEntry entry2(i::Logger::FUNCTION_TAG, "", "bbb");
TokenEnumerator::kNoSecurityToken);
CodeEntry* e1_e2_path[] = {&entry1, &entry2}; CodeEntry* e1_e2_path[] = {&entry1, &entry2};
Vector<CodeEntry*> e1_e2_path_vec( Vector<CodeEntry*> e1_e2_path_vec(
e1_e2_path, sizeof(e1_e2_path) / sizeof(e1_e2_path[0])); e1_e2_path, sizeof(e1_e2_path) / sizeof(e1_e2_path[0]));
@ -373,8 +360,7 @@ TEST(ProfileTreeCalculateTotalTicks) {
CodeEntry* e2_path[] = {&entry2}; CodeEntry* e2_path[] = {&entry2};
Vector<CodeEntry*> e2_path_vec( Vector<CodeEntry*> e2_path_vec(
e2_path, sizeof(e2_path) / sizeof(e2_path[0])); e2_path, sizeof(e2_path) / sizeof(e2_path[0]));
CodeEntry entry3(i::Logger::FUNCTION_TAG, "", "ccc", "", 0, CodeEntry entry3(i::Logger::FUNCTION_TAG, "", "ccc");
TokenEnumerator::kNoSecurityToken);
CodeEntry* e3_path[] = {&entry3}; CodeEntry* e3_path[] = {&entry3};
Vector<CodeEntry*> e3_path_vec( Vector<CodeEntry*> e3_path_vec(
e3_path, sizeof(e3_path) / sizeof(e3_path[0])); e3_path, sizeof(e3_path) / sizeof(e3_path[0]));
@ -432,12 +418,11 @@ TEST(ProfileTreeCalculateTotalTicks) {
TEST(ProfileTreeFilteredClone) { TEST(ProfileTreeFilteredClone) {
ProfileTree source_tree; ProfileTree source_tree;
const int token0 = 0, token1 = 1, token2 = 2; const int token0 = 0, token1 = 1, token2 = 2;
CodeEntry entry1(i::Logger::FUNCTION_TAG, "", "aaa", "", 0, token0); CodeEntry entry1(i::Logger::FUNCTION_TAG, "", "aaa", token0);
CodeEntry entry2(i::Logger::FUNCTION_TAG, "", "bbb", "", 0, token1); CodeEntry entry2(i::Logger::FUNCTION_TAG, "", "bbb", token1);
CodeEntry entry3(i::Logger::FUNCTION_TAG, "", "ccc", "", 0, token0); CodeEntry entry3(i::Logger::FUNCTION_TAG, "", "ccc", token0);
CodeEntry entry4( CodeEntry entry4(i::Logger::FUNCTION_TAG, "", "ddd",
i::Logger::FUNCTION_TAG, "", "ddd", "", 0, TokenEnumerator::kInheritsSecurityToken);
TokenEnumerator::kInheritsSecurityToken);
{ {
CodeEntry* e1_e2_path[] = {&entry1, &entry2}; CodeEntry* e1_e2_path[] = {&entry1, &entry2};
@ -534,14 +519,10 @@ static inline i::Address ToAddress(int n) {
TEST(CodeMapAddCode) { TEST(CodeMapAddCode) {
CodeMap code_map; CodeMap code_map;
CodeEntry entry1(i::Logger::FUNCTION_TAG, "", "aaa", "", 0, CodeEntry entry1(i::Logger::FUNCTION_TAG, "", "aaa");
TokenEnumerator::kNoSecurityToken); CodeEntry entry2(i::Logger::FUNCTION_TAG, "", "bbb");
CodeEntry entry2(i::Logger::FUNCTION_TAG, "", "bbb", "", 0, CodeEntry entry3(i::Logger::FUNCTION_TAG, "", "ccc");
TokenEnumerator::kNoSecurityToken); CodeEntry entry4(i::Logger::FUNCTION_TAG, "", "ddd");
CodeEntry entry3(i::Logger::FUNCTION_TAG, "", "ccc", "", 0,
TokenEnumerator::kNoSecurityToken);
CodeEntry entry4(i::Logger::FUNCTION_TAG, "", "ddd", "", 0,
TokenEnumerator::kNoSecurityToken);
code_map.AddCode(ToAddress(0x1500), &entry1, 0x200); code_map.AddCode(ToAddress(0x1500), &entry1, 0x200);
code_map.AddCode(ToAddress(0x1700), &entry2, 0x100); code_map.AddCode(ToAddress(0x1700), &entry2, 0x100);
code_map.AddCode(ToAddress(0x1900), &entry3, 0x50); code_map.AddCode(ToAddress(0x1900), &entry3, 0x50);
@ -568,10 +549,8 @@ TEST(CodeMapAddCode) {
TEST(CodeMapMoveAndDeleteCode) { TEST(CodeMapMoveAndDeleteCode) {
CodeMap code_map; CodeMap code_map;
CodeEntry entry1(i::Logger::FUNCTION_TAG, "", "aaa", "", 0, CodeEntry entry1(i::Logger::FUNCTION_TAG, "", "aaa");
TokenEnumerator::kNoSecurityToken); CodeEntry entry2(i::Logger::FUNCTION_TAG, "", "bbb");
CodeEntry entry2(i::Logger::FUNCTION_TAG, "", "bbb", "", 0,
TokenEnumerator::kNoSecurityToken);
code_map.AddCode(ToAddress(0x1500), &entry1, 0x200); code_map.AddCode(ToAddress(0x1500), &entry1, 0x200);
code_map.AddCode(ToAddress(0x1700), &entry2, 0x100); code_map.AddCode(ToAddress(0x1700), &entry2, 0x100);
CHECK_EQ(&entry1, code_map.FindEntry(ToAddress(0x1500))); CHECK_EQ(&entry1, code_map.FindEntry(ToAddress(0x1500)));
@ -579,8 +558,7 @@ TEST(CodeMapMoveAndDeleteCode) {
code_map.MoveCode(ToAddress(0x1500), ToAddress(0x1700)); // Deprecate bbb. code_map.MoveCode(ToAddress(0x1500), ToAddress(0x1700)); // Deprecate bbb.
CHECK_EQ(NULL, code_map.FindEntry(ToAddress(0x1500))); CHECK_EQ(NULL, code_map.FindEntry(ToAddress(0x1500)));
CHECK_EQ(&entry1, code_map.FindEntry(ToAddress(0x1700))); CHECK_EQ(&entry1, code_map.FindEntry(ToAddress(0x1700)));
CodeEntry entry3(i::Logger::FUNCTION_TAG, "", "ccc", "", 0, CodeEntry entry3(i::Logger::FUNCTION_TAG, "", "ccc");
TokenEnumerator::kNoSecurityToken);
code_map.AddCode(ToAddress(0x1750), &entry3, 0x100); code_map.AddCode(ToAddress(0x1750), &entry3, 0x100);
CHECK_EQ(NULL, code_map.FindEntry(ToAddress(0x1700))); CHECK_EQ(NULL, code_map.FindEntry(ToAddress(0x1700)));
CHECK_EQ(&entry3, code_map.FindEntry(ToAddress(0x1750))); CHECK_EQ(&entry3, code_map.FindEntry(ToAddress(0x1750)));