AuroraMiddleware/v8
1
0
Fork 0
Code Issues 2 Pull Requests Releases Wiki Activity

[cleanup] Fix clang-tidy warnings for missing overrides

Browse Source 
Remove a redundant default destructor definition and add final to
another which is overriding a virtual constructor.

Bug: v8:9396
Change-Id: I917f3c6058bfae8cbcd3c4ffb0817f78e8214552
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1807360
Commit-Queue: Dan Elphick <delphick@chromium.org>
Commit-Queue: Benedikt Meurer <bmeurer@chromium.org>
Auto-Submit: Dan Elphick <delphick@chromium.org>
Reviewed-by: Benedikt Meurer <bmeurer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#63822}
This commit is contained in:
Dan Elphick 2019-09-17 10:20:40 +01:00 committed by Commit Bot
parent 2172208dbc
commit 3e31cf617a
1 changed files with 1 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/compiler/pipeline.cc
View File

@ -940,7 +940,7 @@ class PipelineCompilationJob final : public OptimizedCompilationJob {
PipelineCompilationJob(Isolate* isolate,
Handle<SharedFunctionInfo> shared_info,
Handle<JSFunction> function);
~PipelineCompilationJob();
~PipelineCompilationJob() final;
protected:
Status PrepareJobImpl(Isolate* isolate) final;
@ -1165,8 +1165,6 @@ class WasmHeapStubCompilationJob final : public OptimizedCompilationJob {
pipeline_(&data_),
wasm_engine_(wasm_engine) {}
~WasmHeapStubCompilationJob() = default;
protected:
Status PrepareJobImpl(Isolate* isolate) final;
Status ExecuteJobImpl() final;