AuroraMiddleware/v8
1
0
Fork 0
Code Issues 2 Pull Requests Releases Wiki Activity

[wasm-simd] [liftoff] Fix i8x16.extract_lane_s on ia32

Browse Source 
movsx_b needs a byte register on ia32, but is using arbitrary gp register.

Bug: v8:9909
Change-Id: I5f31733ccf4ca3b04a3564a9133aec496653079e
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2158928
Reviewed-by: Zhi An Ng <zhin@chromium.org>
Commit-Queue: Fanchen Kong <fanchen.kong@intel.com>
Cr-Commit-Position: refs/heads/master@{#67351}
This commit is contained in:
Kong, Fanchen 2020-04-22 00:50:56 +08:00 committed by Commit Bot
parent f684ef021a
commit 3eb43fbc26
1 changed files with 3 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
src/wasm/baseline/ia32/liftoff-assembler-ia32.h
View File

@ -2822,8 +2822,9 @@ void LiftoffAssembler::emit_i32x4_abs(LiftoffRegister dst,
void LiftoffAssembler::emit_i8x16_extract_lane_s(LiftoffRegister dst,
LiftoffRegister lhs,
uint8_t imm_lane_idx) {
Pextrb(dst.gp(), lhs.fp(), imm_lane_idx);
movsx_b(dst.gp(), dst.gp());
Register byte_reg = liftoff::GetTmpByteRegister(this, dst.gp());
Pextrb(byte_reg, lhs.fp(), imm_lane_idx);
movsx_b(dst.gp(), byte_reg);
}
void LiftoffAssembler::emit_i8x16_extract_lane_u(LiftoffRegister dst,