AuroraMiddleware/v8
1
0
Fork 0
Code Issues 2 Pull Requests Releases Wiki Activity

[Temporal] Use MAYBE_ASSIGN_RETURN_ON_EXCEPTION_VALUE

Browse Source 
1. Move the use of MAYBE_RETURN to MAYBE_ASSIGN_RETURN_ON_EXCEPTION_VALUE
if possible.
2. Remove some MYABE_RETURN in the wrong spot and therefore fix some tests.
3. Change Intl::GetTimeZoneIndex() to return Maybe<int32_t> as index and use
< 0 value to indicate not getting index to make the function signature
simpler.

Bug: v8:11544
Change-Id: I685cbff142e9dea69ef316a1bc180730aef5aec8
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3625839
Reviewed-by: Adam Klein <adamk@chromium.org>
Commit-Queue: Frank Tang <ftang@chromium.org>
Cr-Commit-Position: refs/heads/main@{#80379}
This commit is contained in:
Frank Tang 2022-05-05 10:48:22 -07:00 committed by V8 LUCI CQ
parent a7f4ca5fd0
commit 3f10a72c2f
4 changed files with 410 additions and 412 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
src/objects/intl-objects.cc
View File

@ -2861,18 +2861,16 @@ std::string Intl::TimeZoneIdFromIndex(int32_t index) {
return id;
}
Maybe<bool> Intl::GetTimeZoneIndex(Isolate* isolate, Handle<String> identifier,
int32_t* index) {
int32_t Intl::GetTimeZoneIndex(Isolate* isolate, Handle<String> identifier) {
if (identifier->Equals(*isolate->factory()->UTC_string())) {
*index = 0;
return Just(true);
return 0;
}
std::string identifier_str(identifier->ToCString().get());
std::unique_ptr<icu::TimeZone> tz(
icu::TimeZone::createTimeZone(identifier_str.c_str()));
if (!IsValidTimeZoneName(*tz)) {
return Just(false);
return -1;
}
std::unique_ptr<icu::StringEnumeration> enumeration(
@ -2883,11 +2881,10 @@ Maybe<bool> Intl::GetTimeZoneIndex(Isolate* isolate, Handle<String> identifier,
UErrorCode status = U_ZERO_ERROR;
while (U_SUCCESS(status) &&
(id = enumeration->next(nullptr, status)) != nullptr) {
if (identifier_str == id) {
*index = curr + 1;
return Just(true);
}
curr++;
if (identifier_str == id) {
return curr;
}
}
CHECK(U_SUCCESS(status));
// We should not reach here, the !IsValidTimeZoneName should return earlier

6
src/objects/intl-objects.h
View File

@ -356,8 +356,10 @@ class Intl {
// Function to support Temporal
V8_WARN_UNUSED_RESULT static std::string TimeZoneIdFromIndex(int32_t index);
V8_WARN_UNUSED_RESULT static Maybe<bool> GetTimeZoneIndex(
Isolate* isolate, Handle<String> identifier, int32_t* index);
// Return the index of timezone which later could be used with
// TimeZoneIdFromIndex. Returns -1 while the identifier is not a built-in
// TimeZone name.
static int32_t GetTimeZoneIndex(Isolate* isolate, Handle<String> identifier);
V8_WARN_UNUSED_RESULT static MaybeHandle<String> CanonicalizeTimeZoneName(
Isolate* isolate, Handle<String> identifier);

733
src/objects/js-temporal-objects.cc
View File

File diff suppressed because it is too large Load Diff

68
test/test262/test262.status
View File

@ -301,11 +301,6 @@
# https://github.com/tc39/test262/issues/3252
'built-ins/Temporal/PlainMonthDay/prototype/toPlainDate/basic': [FAIL],
# Extra req of calendar name
# https://github.com/tc39/test262/pull/3261
# https://github.com/tc39/test262/issues/3260
'built-ins/Temporal/Calendar/from/calendar-object-invalid': [FAIL],
# -0
'built-ins/Temporal/PlainDate/prototype/subtract/balance-smaller-units': [FAIL],
'built-ins/Temporal/PlainDate/prototype/since/roundingmode-undefined': [FAIL],
@ -361,10 +356,6 @@
'built-ins/Temporal/Instant/from/instant-string-multiple-offsets': [SKIP],
# Valid calendar in the test
# https://github.com/tc39/test262/pull/3261
'built-ins/Temporal/Calendar/from/calendar-string-not-builtin': [FAIL],
# Calendar.dateAdd with null instead of undefined
# https://github.com/tc39/test262/issues/3262
'built-ins/Temporal/Duration/prototype/add/calendar-dateadd-called-with-options-undefined': [FAIL],
@ -730,13 +721,12 @@
'built-ins/Temporal/Now/plainDateTime/time-zone-undefined': [FAIL],
'built-ins/Temporal/Now/plainDate/timezone-string-datetime': [FAIL],
'built-ins/Temporal/Now/plainTimeISO/timezone-string-datetime': [FAIL],
'built-ins/Temporal/Now/zonedDateTimeISO/timezone-string-datetime': [FAIL],
'built-ins/Temporal/Now/zonedDateTimeISO/timezone-string-multiple-offsets': [FAIL],
'built-ins/Temporal/Now/zonedDateTime/timezone-string-datetime': [FAIL],
'built-ins/Temporal/Now/zonedDateTime/timezone-string-multiple-offsets': [FAIL],
'built-ins/Temporal/PlainDate/compare/argument-object': [FAIL],
'built-ins/Temporal/PlainDate/compare/argument-plaindatetime': [FAIL],
'built-ins/Temporal/PlainDate/compare/argument-string': [FAIL],
'built-ins/Temporal/Now/zonedDateTime/timezone-string-datetime': [SKIP],
'built-ins/Temporal/PlainDate/compare/argument-string-with-utc-designator': [FAIL],
'built-ins/Temporal/PlainDate/compare/argument-zoneddatetime-timezone-getoffsetnanosecondsfor-non-integer': [FAIL],
'built-ins/Temporal/PlainDate/compare/argument-zoneddatetime-timezone-getoffsetnanosecondsfor-not-callable': [FAIL],
@ -932,7 +922,6 @@
'built-ins/Temporal/PlainDate/prototype/with/branding': [FAIL],
'built-ins/Temporal/PlainDate/prototype/with/calendar-fields-iterable': [FAIL],
'built-ins/Temporal/PlainDate/prototype/with/calendar-merge-fields-returns-primitive': [FAIL],
'built-ins/Temporal/PlainDate/prototype/withCalendar/missing-argument': [FAIL],
'built-ins/Temporal/PlainDate/prototype/with/copies-merge-fields-object': [FAIL],
'built-ins/Temporal/PlainDate/prototype/with/infinity-throws-rangeerror': [FAIL],
'built-ins/Temporal/PlainDate/prototype/with/options-invalid': [FAIL],
@ -1140,7 +1129,6 @@
'built-ins/Temporal/PlainDateTime/prototype/with/branding': [FAIL],
'built-ins/Temporal/PlainDateTime/prototype/with/calendar-fields-iterable': [FAIL],
'built-ins/Temporal/PlainDateTime/prototype/with/calendar-merge-fields-returns-primitive': [FAIL],
'built-ins/Temporal/PlainDateTime/prototype/withCalendar/missing-argument': [FAIL],
'built-ins/Temporal/PlainDateTime/prototype/with/copies-merge-fields-object': [FAIL],
'built-ins/Temporal/PlainDateTime/prototype/with/infinity-throws-rangeerror': [FAIL],
'built-ins/Temporal/PlainDateTime/prototype/with/options-undefined': [FAIL],
@ -1558,9 +1546,7 @@
'built-ins/Temporal/PlainYearMonth/prototype/with/overflow-undefined': [FAIL],
'built-ins/Temporal/PlainYearMonth/prototype/with/overflow-wrong-type': [FAIL],
'built-ins/Temporal/PlainYearMonth/prototype/with/subclassing-ignored': [FAIL],
'built-ins/Temporal/TimeZone/from/argument-object-invalid': [FAIL],
'built-ins/Temporal/TimeZone/from/argument-primitive': [FAIL],
'built-ins/Temporal/TimeZone/from/timezone-string-datetime': [FAIL],
'built-ins/Temporal/TimeZone/from/timezone-string-datetime': [SKIP],
'built-ins/Temporal/TimeZone/from/timezone-string-multiple-offsets': [FAIL],
'built-ins/Temporal/TimeZone/prototype/getInstantFor/argument-plaindate': [FAIL],
'built-ins/Temporal/TimeZone/prototype/getInstantFor/argument-zoneddatetime-balance-negative-time-units': [FAIL],
@ -1961,7 +1947,6 @@
'built-ins/Temporal/ZonedDateTime/prototype/with/branding': [FAIL],
'built-ins/Temporal/ZonedDateTime/prototype/with/calendar-fields-iterable': [FAIL],
'built-ins/Temporal/ZonedDateTime/prototype/with/calendar-merge-fields-returns-primitive': [FAIL],
'built-ins/Temporal/ZonedDateTime/prototype/withCalendar/missing-argument': [FAIL],
'built-ins/Temporal/ZonedDateTime/prototype/withCalendar/subclassing-ignored': [FAIL],
'built-ins/Temporal/ZonedDateTime/prototype/with/copies-merge-fields-object': [FAIL],
'built-ins/Temporal/ZonedDateTime/prototype/with/disambiguation-invalid-string': [FAIL],
@ -2018,7 +2003,6 @@
'built-ins/Temporal/ZonedDateTime/prototype/with/timezone-getoffsetnanosecondsfor-wrong-type': [FAIL],
'built-ins/Temporal/ZonedDateTime/prototype/with/timezone-getpossibleinstantsfor-iterable': [FAIL],
'built-ins/Temporal/ZonedDateTime/prototype/withTimeZone/subclassing-ignored': [FAIL],
'built-ins/Temporal/ZonedDateTime/prototype/withTimeZone/timezone-string-datetime': [FAIL],
'built-ins/Temporal/ZonedDateTime/prototype/withTimeZone/timezone-string-multiple-offsets': [FAIL],
'built-ins/Temporal/ZonedDateTime/prototype/year/branding': [FAIL],
'built-ins/Temporal/ZonedDateTime/prototype/year/calendar-returns-infinity': [FAIL],
@ -2026,7 +2010,6 @@
'built-ins/Temporal/ZonedDateTime/prototype/year/timezone-getoffsetnanosecondsfor-not-callable': [FAIL],
'built-ins/Temporal/ZonedDateTime/prototype/year/timezone-getoffsetnanosecondsfor-out-of-range': [FAIL],
'built-ins/Temporal/ZonedDateTime/prototype/year/timezone-getoffsetnanosecondsfor-wrong-type': [FAIL],
'built-ins/Temporal/ZonedDateTime/timezone-string-datetime': [FAIL],
'intl402/DateTimeFormat/prototype/formatRange/temporal-objects-resolved-time-zone': [FAIL],
'intl402/DateTimeFormat/prototype/formatRangeToParts/temporal-objects-resolved-time-zone': [FAIL],
'intl402/DateTimeFormat/prototype/format/temporal-objects-resolved-time-zone': [FAIL],
@ -2173,12 +2156,9 @@
'built-ins/Temporal/Instant/prototype/subtract/argument-string-fractional-units-rounding-mode': [FAIL],
'built-ins/Temporal/Instant/prototype/until/largestunit-smallestunit-mismatch': [FAIL],
'built-ins/Temporal/Instant/prototype/until/year-zero': [FAIL],
'built-ins/Temporal/Now/plainDate/calendar-undefined': [FAIL],
'built-ins/Temporal/Now/plainDateISO/return-value': [FAIL],
'built-ins/Temporal/Now/plainDateTime/calendar-undefined': [FAIL],
'built-ins/Temporal/Now/plainDateTimeISO/return-value-calendar': [FAIL],
'built-ins/Temporal/Now/plainTimeISO/return-value': [FAIL],
'built-ins/Temporal/Now/zonedDateTime/calendar-undefined': [FAIL],
'built-ins/Temporal/PlainDate/compare/year-zero': [FAIL],
'built-ins/Temporal/PlainDate/from/year-zero': [FAIL],
'built-ins/Temporal/PlainDate/prototype/add/argument-invalid-duration': [FAIL],
@ -2677,38 +2657,24 @@
'intl402/Temporal/PlainDateTime/prototype/withPlainDate/argument-string-calendar': [FAIL],
'built-ins/Temporal/Calendar/from/calendar-number': [FAIL],
'built-ins/Temporal/Calendar/from/calendar-wrong-type': [FAIL],
'built-ins/Temporal/Calendar/prototype/dateAdd/argument-propertybag-calendar-number': [FAIL],
'built-ins/Temporal/Calendar/prototype/dateAdd/argument-propertybag-calendar-wrong-type': [FAIL],
'built-ins/Temporal/Calendar/prototype/dateUntil/argument-propertybag-calendar-number': [FAIL],
'built-ins/Temporal/Calendar/prototype/dateUntil/argument-propertybag-calendar-wrong-type': [FAIL],
'built-ins/Temporal/Calendar/prototype/day/argument-propertybag-calendar-number': [FAIL],
'built-ins/Temporal/Calendar/prototype/day/argument-propertybag-calendar-wrong-type': [FAIL],
'built-ins/Temporal/Calendar/prototype/day/basic': [FAIL],
'built-ins/Temporal/Calendar/prototype/dayOfWeek/argument-propertybag-calendar-number': [FAIL],
'built-ins/Temporal/Calendar/prototype/dayOfWeek/argument-propertybag-calendar-wrong-type': [FAIL],
'built-ins/Temporal/Calendar/prototype/dayOfYear/argument-propertybag-calendar-number': [FAIL],
'built-ins/Temporal/Calendar/prototype/dayOfYear/argument-propertybag-calendar-wrong-type': [FAIL],
'built-ins/Temporal/Calendar/prototype/daysInMonth/argument-propertybag-calendar-number': [FAIL],
'built-ins/Temporal/Calendar/prototype/daysInMonth/argument-propertybag-calendar-wrong-type': [FAIL],
'built-ins/Temporal/Calendar/prototype/daysInWeek/argument-propertybag-calendar-number': [FAIL],
'built-ins/Temporal/Calendar/prototype/daysInWeek/argument-propertybag-calendar-wrong-type': [FAIL],
'built-ins/Temporal/Calendar/prototype/daysInYear/argument-propertybag-calendar-number': [FAIL],
'built-ins/Temporal/Calendar/prototype/daysInYear/argument-propertybag-calendar-wrong-type': [FAIL],
'built-ins/Temporal/Calendar/prototype/inLeapYear/argument-propertybag-calendar-number': [FAIL],
'built-ins/Temporal/Calendar/prototype/inLeapYear/argument-propertybag-calendar-wrong-type': [FAIL],
'built-ins/Temporal/Calendar/prototype/month/argument-propertybag-calendar-number': [FAIL],
'built-ins/Temporal/Calendar/prototype/month/argument-propertybag-calendar-wrong-type': [FAIL],
'built-ins/Temporal/Calendar/prototype/monthCode/argument-propertybag-calendar-number': [FAIL],
'built-ins/Temporal/Calendar/prototype/monthCode/argument-propertybag-calendar-wrong-type': [FAIL],
'built-ins/Temporal/Calendar/prototype/monthsInYear/argument-propertybag-calendar-number': [FAIL],
'built-ins/Temporal/Calendar/prototype/monthsInYear/argument-propertybag-calendar-wrong-type': [FAIL],
'built-ins/Temporal/Calendar/prototype/weekOfYear/argument-number': [FAIL],
'built-ins/Temporal/Calendar/prototype/weekOfYear/argument-propertybag-calendar-number': [FAIL],
'built-ins/Temporal/Calendar/prototype/weekOfYear/argument-propertybag-calendar-wrong-type': [FAIL],
'built-ins/Temporal/Calendar/prototype/weekOfYear/argument-wrong-type': [FAIL],
'built-ins/Temporal/Calendar/prototype/year/argument-propertybag-calendar-number': [FAIL],
'built-ins/Temporal/Calendar/prototype/year/argument-propertybag-calendar-wrong-type': [FAIL],
'built-ins/Temporal/Duration/compare/timezone-wrong-type': [FAIL],
'built-ins/Temporal/Duration/prototype/add/relativeto-number': [FAIL],
'built-ins/Temporal/Duration/prototype/add/relativeto-propertybag-calendar-number': [FAIL],
@ -2753,26 +2719,14 @@
'built-ins/Temporal/Instant/prototype/until/argument-wrong-type': [FAIL],
'built-ins/Temporal/Instant/prototype/until/instant-string-sub-minute-offset': [FAIL],
'built-ins/Temporal/Now/plainDate/calendar-number': [FAIL],
'built-ins/Temporal/Now/plainDate/calendar-wrong-type': [FAIL],
'built-ins/Temporal/Now/plainDateISO/timezone-wrong-type': [FAIL],
'built-ins/Temporal/Now/plainDateTime/calendar-number': [FAIL],
'built-ins/Temporal/Now/plainDateTime/calendar-wrong-type': [FAIL],
'built-ins/Temporal/Now/plainDateTimeISO/timezone-wrong-type': [FAIL],
'built-ins/Temporal/Now/plainDateTime/timezone-wrong-type': [FAIL],
'built-ins/Temporal/Now/plainDate/timezone-wrong-type': [FAIL],
'built-ins/Temporal/Now/plainTimeISO/timezone-wrong-type': [FAIL],
'built-ins/Temporal/Now/zonedDateTime/calendar-number': [FAIL],
'built-ins/Temporal/Now/zonedDateTime/calendar-wrong-type': [FAIL],
'built-ins/Temporal/Now/zonedDateTimeISO/timezone-wrong-type': [FAIL],
'built-ins/Temporal/Now/zonedDateTime/timezone-wrong-type': [FAIL],
'built-ins/Temporal/PlainDate/calendar-number': [FAIL],
'built-ins/Temporal/PlainDate/calendar-wrong-type': [FAIL],
'built-ins/Temporal/PlainDate/compare/argument-number': [FAIL],
'built-ins/Temporal/PlainDate/compare/argument-propertybag-calendar-number': [FAIL],
'built-ins/Temporal/PlainDate/compare/argument-propertybag-calendar-wrong-type': [FAIL],
'built-ins/Temporal/PlainDate/compare/argument-wrong-type': [FAIL],
'built-ins/Temporal/PlainDate/from/argument-propertybag-calendar-number': [FAIL],
'built-ins/Temporal/PlainDate/from/argument-propertybag-calendar-wrong-type': [FAIL],
'built-ins/Temporal/PlainDate/prototype/equals/argument-number': [FAIL],
'built-ins/Temporal/PlainDate/prototype/equals/argument-propertybag-calendar-number': [FAIL],
'built-ins/Temporal/PlainDate/prototype/equals/argument-propertybag-calendar-wrong-type': [FAIL],
@ -2791,15 +2745,12 @@
'built-ins/Temporal/PlainDate/prototype/until/argument-propertybag-calendar-wrong-type': [FAIL],
'built-ins/Temporal/PlainDate/prototype/until/argument-wrong-type': [FAIL],
'built-ins/Temporal/PlainDate/prototype/withCalendar/calendar-number': [FAIL],
'built-ins/Temporal/PlainDate/prototype/withCalendar/calendar-wrong-type': [FAIL],
'built-ins/Temporal/PlainDateTime/calendar-number': [FAIL],
'built-ins/Temporal/PlainDateTime/calendar-wrong-type': [FAIL],
'built-ins/Temporal/PlainDateTime/compare/argument-number': [FAIL],
'built-ins/Temporal/PlainDateTime/compare/argument-propertybag-calendar-number': [FAIL],
'built-ins/Temporal/PlainDateTime/compare/argument-propertybag-calendar-wrong-type': [FAIL],
'built-ins/Temporal/PlainDateTime/compare/argument-wrong-type': [FAIL],
'built-ins/Temporal/PlainDateTime/from/argument-propertybag-calendar-number': [FAIL],
'built-ins/Temporal/PlainDateTime/from/argument-propertybag-calendar-wrong-type': [FAIL],
'built-ins/Temporal/PlainDateTime/from/limits': [FAIL],
'built-ins/Temporal/PlainDateTime/prototype/add/limits': [FAIL],
'built-ins/Temporal/PlainDateTime/prototype/equals/argument-number': [FAIL],
@ -2821,7 +2772,6 @@
'built-ins/Temporal/PlainDateTime/prototype/until/argument-propertybag-calendar-wrong-type': [FAIL],
'built-ins/Temporal/PlainDateTime/prototype/until/argument-wrong-type': [FAIL],
'built-ins/Temporal/PlainDateTime/prototype/withCalendar/calendar-number': [FAIL],
'built-ins/Temporal/PlainDateTime/prototype/withCalendar/calendar-wrong-type': [FAIL],
'built-ins/Temporal/PlainDateTime/prototype/withPlainDate/argument-number': [FAIL],
'built-ins/Temporal/PlainDateTime/prototype/withPlainDate/argument-propertybag-calendar-number': [FAIL],
'built-ins/Temporal/PlainDateTime/prototype/withPlainDate/argument-propertybag-calendar-wrong-type': [FAIL],
@ -2829,7 +2779,6 @@
'built-ins/Temporal/PlainDateTime/prototype/withPlainTime/argument-number': [FAIL],
'built-ins/Temporal/PlainDateTime/prototype/withPlainTime/argument-wrong-type': [FAIL],
'built-ins/Temporal/PlainMonthDay/calendar-number': [FAIL],
'built-ins/Temporal/PlainMonthDay/calendar-wrong-type': [FAIL],
'built-ins/Temporal/PlainMonthDay/from/argument-number': [FAIL],
'built-ins/Temporal/PlainMonthDay/from/argument-propertybag-calendar-number': [FAIL],
'built-ins/Temporal/PlainMonthDay/from/argument-propertybag-calendar-wrong-type': [FAIL],
@ -2857,7 +2806,6 @@
'built-ins/Temporal/PlainTime/prototype/until/argument-wrong-type': [FAIL],
'built-ins/Temporal/PlainTime/prototype/until/plaintime-propertybag-no-time-units': [FAIL],
'built-ins/Temporal/PlainYearMonth/calendar-number': [FAIL],
'built-ins/Temporal/PlainYearMonth/calendar-wrong-type': [FAIL],
'built-ins/Temporal/PlainYearMonth/compare/argument-number': [FAIL],
'built-ins/Temporal/PlainYearMonth/compare/argument-propertybag-calendar-number': [FAIL],
'built-ins/Temporal/PlainYearMonth/compare/argument-propertybag-calendar-wrong-type': [FAIL],
@ -2876,10 +2824,8 @@
'built-ins/Temporal/PlainYearMonth/prototype/until/argument-propertybag-calendar-number': [FAIL],
'built-ins/Temporal/PlainYearMonth/prototype/until/argument-propertybag-calendar-wrong-type': [FAIL],
'built-ins/Temporal/PlainYearMonth/prototype/until/argument-wrong-type': [FAIL],
'built-ins/Temporal/TimeZone/from/timezone-wrong-type': [FAIL],
'built-ins/Temporal/TimeZone/prototype/getInstantFor/argument-number': [FAIL],
'built-ins/Temporal/TimeZone/prototype/getInstantFor/argument-propertybag-calendar-number': [FAIL],
'built-ins/Temporal/TimeZone/prototype/getInstantFor/argument-propertybag-calendar-wrong-type': [FAIL],
'built-ins/Temporal/TimeZone/prototype/getPlainDateTimeFor/argument-object-tostring': [FAIL],
'built-ins/Temporal/TimeZone/prototype/getPlainDateTimeFor/argument-wrong-type': [FAIL],
'built-ins/Temporal/TimeZone/prototype/getPlainDateTimeFor/calendar-number': [FAIL],
@ -2891,7 +2837,6 @@
'built-ins/Temporal/TimeZone/prototype/getPossibleInstantsFor/argument-propertybag-calendar-wrong-type': [FAIL],
'built-ins/Temporal/TimeZone/prototype/getPossibleInstantsFor/argument-wrong-type': [FAIL],
'built-ins/Temporal/ZonedDateTime/calendar-number': [FAIL],
'built-ins/Temporal/ZonedDateTime/calendar-wrong-type': [FAIL],
'built-ins/Temporal/ZonedDateTime/compare/argument-propertybag-calendar-number': [FAIL],
'built-ins/Temporal/ZonedDateTime/compare/argument-propertybag-calendar-wrong-type': [FAIL],
'built-ins/Temporal/ZonedDateTime/compare/argument-wrong-type': [FAIL],
@ -2913,16 +2858,13 @@
'built-ins/Temporal/ZonedDateTime/prototype/until/argument-wrong-type': [FAIL],
'built-ins/Temporal/ZonedDateTime/prototype/until/timezone-wrong-type': [FAIL],
'built-ins/Temporal/ZonedDateTime/prototype/withCalendar/calendar-number': [FAIL],
'built-ins/Temporal/ZonedDateTime/prototype/withCalendar/calendar-wrong-type': [FAIL],
'built-ins/Temporal/ZonedDateTime/prototype/withPlainDate/argument-number': [FAIL],
'built-ins/Temporal/ZonedDateTime/prototype/withPlainDate/argument-propertybag-calendar-number': [FAIL],
'built-ins/Temporal/ZonedDateTime/prototype/withPlainDate/argument-propertybag-calendar-wrong-type': [FAIL],
'built-ins/Temporal/ZonedDateTime/prototype/withPlainDate/argument-wrong-type': [FAIL],
'built-ins/Temporal/ZonedDateTime/prototype/withPlainTime/argument-number': [FAIL],
'built-ins/Temporal/ZonedDateTime/prototype/withPlainTime/argument-wrong-type': [FAIL],
'built-ins/Temporal/ZonedDateTime/prototype/withTimeZone/timezone-wrong-type': [FAIL],
'built-ins/Temporal/ZonedDateTime/timezone-string-multiple-offsets': [FAIL],
'built-ins/Temporal/ZonedDateTime/timezone-wrong-type': [FAIL],
'intl402/Temporal/Calendar/prototype/era/argument-number': [FAIL],
'intl402/Temporal/Calendar/prototype/era/argument-propertybag-calendar-number': [FAIL],
'intl402/Temporal/Calendar/prototype/era/argument-propertybag-calendar-wrong-type': [FAIL],
@ -2994,6 +2936,11 @@
'intl402/DurationFormat/prototype/toStringTag/toString': [FAIL],
'intl402/DurationFormat/prototype/toStringTag/toStringTag': [FAIL],
# Flaky tests
'built-ins/Temporal/Now/zonedDateTimeISO/timezone-string-datetime': [SKIP],
'built-ins/Temporal/ZonedDateTime/prototype/withTimeZone/timezone-string-datetime': [SKIP],
'built-ins/Temporal/ZonedDateTime/timezone-string-datetime': [SKIP],
# Test passed in no_i18n only.
'built-ins/Temporal/Calendar/prototype/dateFromFields/overflow-undefined': [SKIP],
'built-ins/Temporal/Calendar/prototype/dateFromFields/overflow-wrong-type': [SKIP],
@ -3061,7 +3008,6 @@
'built-ins/Temporal/Calendar/prototype/dateAdd/overflow-undefined': [SKIP],
'built-ins/Temporal/Calendar/prototype/dateAdd/overflow-wrong-type': [SKIP],
# Flaky Temporal tests
'built-ins/Temporal/Instant/from/instant-string-sub-minute-offset': [SKIP],
'built-ins/Temporal/Instant/from/basic': [SKIP],