AuroraMiddleware/v8
1
0
Fork 0
Code Issues 2 Pull Requests Releases Wiki Activity

[heap] Cleanup: Use std::atomic<T> instead of base::AtomicNumber<T> in heap.

Browse Source 
Bug: chromium:842083
Change-Id: Ic28d47df055277878cb8e066cd2276cedf06d3cf
Reviewed-on: https://chromium-review.googlesource.com/1054074
Commit-Queue: Hannes Payer <hpayer@chromium.org>
Reviewed-by: Ulan Degenbaev <ulan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#53134}
This commit is contained in:
Hannes Payer 2018-05-11 22:37:54 +02:00 committed by Commit Bot
parent 3ed5dfb8a3
commit 3fc8937ed1
3 changed files with 9 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/heap/heap-inl.h
View File

@ -562,11 +562,11 @@ int Heap::GetNextTemplateSerialNumber() {
AlwaysAllocateScope::AlwaysAllocateScope(Isolate* isolate)
: heap_(isolate->heap()) {
heap_->always_allocate_scope_count_.Increment(1);
heap_->always_allocate_scope_count_++;
}
AlwaysAllocateScope::~AlwaysAllocateScope() {
heap_->always_allocate_scope_count_.Decrement(1);
heap_->always_allocate_scope_count_--;
}
CodeSpaceMemoryModificationScope::CodeSpaceMemoryModificationScope(Heap* heap)

1
src/heap/heap.cc
View File

@ -141,6 +141,7 @@ Heap::Heap()
: external_memory_(0),
external_memory_limit_(kExternalAllocationSoftLimit),
external_memory_at_last_mark_compact_(0),
external_memory_concurrently_freed_(0),
isolate_(nullptr),
code_range_size_(0),
// semispace_size_ should be a power of 2 and old_generation_size_ should

12
src/heap/heap.h
View File

@ -936,12 +936,12 @@ class Heap {
void update_external_memory(int64_t delta) { external_memory_ += delta; }
void update_external_memory_concurrently_freed(intptr_t freed) {
external_memory_concurrently_freed_.Increment(freed);
external_memory_concurrently_freed_ += freed;
}
void account_external_memory_concurrently_freed() {
external_memory_ -= external_memory_concurrently_freed_.Value();
external_memory_concurrently_freed_.SetValue(0);
external_memory_ -= external_memory_concurrently_freed_;
external_memory_concurrently_freed_ = 0;
}
void CompactFixedArraysOfWeakCells();
@ -2113,7 +2113,7 @@ class Heap {
return old_generation_allocation_limit_;
}
bool always_allocate() { return always_allocate_scope_count_.Value() != 0; }
bool always_allocate() { return always_allocate_scope_count_ != 0; }
bool CanExpandOldGeneration(size_t size);
@ -2220,7 +2220,7 @@ class Heap {
int64_t external_memory_at_last_mark_compact_;
// The amount of memory that has been freed concurrently.
base::AtomicNumber<intptr_t> external_memory_concurrently_freed_;
std::atomic<intptr_t> external_memory_concurrently_freed_;
// This can be calculated directly from a pointer to the heap; however, it is
// more expedient to get at the isolate directly from within Heap methods.
@ -2253,7 +2253,7 @@ class Heap {
// This is not the depth of nested AlwaysAllocateScope's but rather a single
// count, as scopes can be acquired from multiple tasks (read: threads).
base::AtomicNumber<size_t> always_allocate_scope_count_;
std::atomic<size_t> always_allocate_scope_count_;
// Stores the memory pressure level that set by MemoryPressureNotification
// and reset by a mark-compact garbage collection.