From 40a968bec45551c949e0f17062b4b392290006ef Mon Sep 17 00:00:00 2001 From: "neis@chromium.org" Date: Tue, 30 Sep 2014 10:37:47 +0000 Subject: [PATCH] Temporarily remove unsound use of Maybe until we have a proper fix. R=rossberg@chromium.org BUG= Review URL: https://codereview.chromium.org/609073002 git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@24321 ce2b1a6d-e550-0410-aec6-3dcde31c8c00 --- src/compiler/js-typed-lowering.cc | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/compiler/js-typed-lowering.cc b/src/compiler/js-typed-lowering.cc index e6610a72dd..40854abb1a 100644 --- a/src/compiler/js-typed-lowering.cc +++ b/src/compiler/js-typed-lowering.cc @@ -383,6 +383,7 @@ Reduction JSTypedLowering::ReduceJSStrictEqual(Node* node, bool invert) { : jsgraph()->TrueConstant()); } } + /* TODO(neis): This is currently unsound. if (!r.left_type()->Maybe(r.right_type())) { // Type intersection is empty; === is always false unless both // inputs could be strings (one internalized and one not). @@ -391,6 +392,7 @@ Reduction JSTypedLowering::ReduceJSStrictEqual(Node* node, bool invert) { : jsgraph()->FalseConstant()); } } + */ if (r.OneInputIs(Type::Undefined())) { return r.ChangeToPureOperator( simplified()->ReferenceEqual(Type::Undefined()), invert);