From 40d2fab61c5c1b62abaffe3139f2913f873fd163 Mon Sep 17 00:00:00 2001 From: Michael Achenbach Date: Wed, 11 May 2022 14:04:14 +0200 Subject: [PATCH] [foozzie] Disallow flags with too many known failures This filters the flags --maglev and --no-use-map-space when passed to foozzie. Most open bugs are known or spurious, but all take up the limited hashes for correctness bugs, which prevents finding other bugs. Filtering on the source-side will make those reports appear as fixed. Bug: chromium:1324097, chromium:1317880 Change-Id: Ibf1b04bdfdd2395c3bda5787b4843c6bb5ca8f8e No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3641171 Reviewed-by: Leszek Swirski Commit-Queue: Leszek Swirski Auto-Submit: Michael Achenbach Cr-Commit-Position: refs/heads/main@{#80468} --- tools/clusterfuzz/foozzie/v8_foozzie.py | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/tools/clusterfuzz/foozzie/v8_foozzie.py b/tools/clusterfuzz/foozzie/v8_foozzie.py index 891198b68e..4dfaf2df0e 100755 --- a/tools/clusterfuzz/foozzie/v8_foozzie.py +++ b/tools/clusterfuzz/foozzie/v8_foozzie.py @@ -173,6 +173,12 @@ KNOWN_FAILURES = { # Flags that are already crashy during smoke tests should not be used. DISALLOWED_FLAGS = [ '--gdbjit', + + # TODO(https://crbug.com/1324097): Enable once maglev is more stable. + '--maglev', + + # The flag is unpredictably chatty. + '--no-use-map-space', ]