AuroraMiddleware/v8
1
0
Fork 0
Code Issues 2 Pull Requests Releases Wiki Activity

[clang-tidy] Remove unneeded casts

Browse Source 
unsigned is (uint32_t) in both branches, so the cast can be removed.

See
https://clang.llvm.org/extra/clang-tidy/checks/google-readability-casting.html
and https://google.github.io/styleguide/cppguide.html#Casting.

Bug: v8:10488
Change-Id: I6d669e36509049fde449d8455c34d140f95b9b8b
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2233989
Commit-Queue: Zhi An Ng <zhin@chromium.org>
Reviewed-by: Jakob Kummerow <jkummerow@chromium.org>
Cr-Commit-Position: refs/heads/master@{#68303}
This commit is contained in:
Ng Zhi An 2020-06-10 11:01:57 -07:00 committed by Commit Bot
parent 58af0be444
commit 414522e09b
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/extensions/cputracemark-extension.cc
View File

@ -34,12 +34,12 @@ void CpuTraceMarkExtension::Mark(
#if defined(__i386__) && defined(__pic__)
__asm__ __volatile__("push %%ebx; cpuid; pop %%ebx"
: "=a"(magic_dummy)
: "a"(0x4711 | ((unsigned)(param) << 16))
: "a"(0x4711 | (param << 16))
: "ecx", "edx");
#else
__asm__ __volatile__("cpuid"
: "=a"(magic_dummy)
: "a"(0x4711 | ((unsigned)(param) << 16))
: "a"(0x4711 | (param << 16))
: "ecx", "edx", "ebx");
#endif // defined(__i386__) && defined(__pic__)